Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RNGP - ENTRY_FILE should resolve relative paths from root #36193

Closed
wants to merge 1 commit into from
Closed

RNGP - ENTRY_FILE should resolve relative paths from root #36193

wants to merge 1 commit into from

Conversation

cortinico
Copy link
Contributor

Summary:
Fixes #36186

Changelog:
[Android] [Fixed] - ENTRY_FILE should resolve relative paths from root

Differential Revision: D43392121

@cortinico @facebook-github-bot
RNGP - ENTRY_FILE should resolve relative paths from root
d3c2303 
Summary:
Fixes facebook#36186

Changelog:
[Android] [Fixed] - ENTRY_FILE should resolve relative paths from root

Differential Revision: D43392121

fbshipit-source-id: 0b3a704e764ac620ab3c935270041e7db8f17ee2
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Feb 17, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43392121

@react-native-bot react-native-bot added Bug Platform: Android Android applications. labels Feb 17, 2023
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,451,399 -2,934
android hermes armeabi-v7a 7,774,782 -2,954
android hermes x86 8,927,004 -3,985
android hermes x86_64 8,784,617 -3,888
android jsc arm64-v8a 6,668,092 +0
android jsc armeabi-v7a 7,462,048 +0
android jsc x86 9,192,215 +0
android jsc x86_64 6,893,219 +0

Base commit: 3218680
Branch: main

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Feb 17, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 6dde1dc.

cortinico added a commit that referenced this pull request Mar 6, 2023
@cortinico
RNGP - ENTRY_FILE should resolve relative paths from root (#36193)
3890747 
Summary:
Pull Request resolved: #36193

Fixes #36186

Changelog:
[Android] [Fixed] - ENTRY_FILE should resolve relative paths from root

Reviewed By: cipolleschi

Differential Revision: D43392121

fbshipit-source-id: ddf302d333c5fc5f822e0635a73e5b52470140ee
kelset pushed a commit that referenced this pull request Mar 6, 2023
@cortinico @kelset
RNGP - ENTRY_FILE should resolve relative paths from root (#36193)
f2bfe91 
Summary:
Pull Request resolved: #36193

Fixes #36186

Changelog:
[Android] [Fixed] - ENTRY_FILE should resolve relative paths from root

Reviewed By: cipolleschi

Differential Revision: D43392121

fbshipit-source-id: ddf302d333c5fc5f822e0635a73e5b52470140ee
@NOUIY NOUIY mentioned this pull request Mar 30, 2023
Open
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
@cortinico @OlimpiaZurek
RNGP - ENTRY_FILE should resolve relative paths from root (facebook#3…
57c00c8 
…6193)

Summary:
Pull Request resolved: facebook#36193

Fixes facebook#36186

Changelog:
[Android] [Fixed] - ENTRY_FILE should resolve relative paths from root

Reviewed By: cipolleschi

Differential Revision: D43392121

fbshipit-source-id: ddf302d333c5fc5f822e0635a73e5b52470140ee
@cipolleschi cipolleschi mentioned this pull request Aug 16, 2023
Merged
@cipolleschi cipolleschi mentioned this pull request Sep 21, 2023
Merged
@cipolleschi cipolleschi mentioned this pull request Oct 11, 2023
Merged
@cipolleschi cipolleschi mentioned this pull request Nov 1, 2023
Merged
This was referenced Jan 8, 2024
Merged
Merged
@cipolleschi cipolleschi mentioned this pull request Mar 6, 2024
Merged
@cipolleschi cipolleschi mentioned this pull request Apr 5, 2024
Closed
@cipolleschi cipolleschi mentioned this pull request Apr 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner Platform: Android Android applications.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Android] Using relative paths for ENTRY_FILE now end up in build failure
4 participants
@cortinico @facebook-github-bot @analysis-bot @react-native-bot