refactor(bump-all-updated-packages): use tag instead of custom commit message #36220
Conversation
facebook-github-bot
added
CLA Signed
|
@hoxyq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
hoxyq
force-pushed
the
packages-ci/update-validation
branch
from
b39c08b
to
91fc8de
Compare
|
@hoxyq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
| const hasSpecificPublishTag = | ||
| commitMessage.includes(PUBLISH_PACKAGES_TAG); |
There was a problem hiding this comment.
I would maybe keep both logic in OR, what do you think?
There was a problem hiding this comment.
If we keep both, but cli (npm run bump-all-updated-packages) will only append @publish-... tag, this means that some users might put this commit message manually
I think its better to avoid this and keep cli as the only right way to do packages bumping
There was a problem hiding this comment.
But yeah, I understand that user can still append this tag manually and this will trigger the publishing process
hoxyq
force-pushed
the
packages-ci/update-validation
branch
2 times, most recently
from
72bfae8
to
6badfee
Compare
|
@hoxyq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
(small sidenote: let's make sure to update the wiki to reflect the latest once this is merged) |
Base commit: 5d6f21d |
|
Hey @hoxyq, For example D43619512 from @cipolleschi had an So we'd need to either search for |
Thanks for highlighting this, I will check if Phabricator strips only |
… message (facebook#36220) Summary: Having custom commit message script is not an option for `main` branch, because we have internal tooling, which strips `[x]` tags from commit messages before merging them into `main` branch. Instead of constant commit message, we are now using a tag which will be concatenated with the commit message, which was entered via interactive commit dialog, see demo below. ## Changelog [Internal] - updated validation in bumping packages script Pull Request resolved: facebook#36220 Test Plan: https://user-images.githubusercontent.com/28902667/220163767-015bf37b-6914-4df2-84d9-aa25fb2887d3.mov Reviewed By: cortinico Differential Revision: D43443597 Pulled By: hoxyq fbshipit-source-id: 08e5e08524a1d934fbb35529e025358d7bf3b203
Summary
Having custom commit message script is not an option for
mainbranch, because we have internal tooling, which strips[x]tags from commit messages before merging them intomainbranch.Instead of constant commit message, we are now using a tag which will be concatenated with the commit message, which was entered via interactive commit dialog, see demo below.
Changelog
[Internal] - updated validation in bumping packages script
Test Plan
Screen.Recording.2023-02-20.at.16.49.44.mov