Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-picking changes in CI scripts for packages versions bumping #36323

Merged

Commits on Feb 28, 2023

  1. fix: update executor for packages publishing workflow

    Summary:
    Changelog: [Internal]
    
    - While working on 0.71.3, it was discovered that `react-native-codegen` package is being published almost empty (without `lib` folder)
    - The reason for it is that `prepare` script is not being executed
    - The main reason for it is npm v6, which requires adding `unsafe-perm` flag for it: https://www.vinayraghu.com/blog/npm-unsafe-perm
    - Instead of using this flag, changing executor to `nodelts`, which has node v18 and npm v8
    - Also adding `run_yarn` before running the script, because `react-native/codegen` uses external dependencies (such as rimraf) for its build scripts
    
    Differential Revision: D43248175
    
    fbshipit-source-id: ea696aae5b75cb284db380d2040e678bb24a0eb4
    hoxyq committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    411491e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ac635f9 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2023

  1. fix: update publishing packages tag message prefix (facebook#36348)

    Summary:
    Pull Request resolved: facebook#36348
    
    Changelog: [Internal]
    
    Turns out that Phabricator strips `@` symbol from `@...` tags when exports commits to GitHub. Proposing to use `#` instead.
    
    #publish-packages-to-npm
    
    Reviewed By: cortinico
    
    Differential Revision: D43712415
    
    fbshipit-source-id: 86fc728eb0cb63afb6a9fe592a9ae998da2ce2e4
    hoxyq committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    9c4d0a8 View commit details
    Browse the repository at this point in the history