Remove DevServerHelper.symbolicateStackTrace and DevServerHelper.openStackFrameCall. #36652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D44257731 |
Base commit: 3506c8d |
|
This pull request was exported from Phabricator. Differential Revision: D44257731 |
GijsWeterings
force-pushed
the
export-D44257731
branch
from
a9d213a
to
4ca6f90
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44257731 |
GijsWeterings
added a commit
to GijsWeterings/react-native
that referenced
this pull request
Apr 5, 2023
…StackFrameCall. (facebook#36652) Summary: Pull Request resolved: facebook#36652 I can't find any usecases for them, and JavaScript stack symbolication during development should probably just exclusively be done from the JS environment. Changelog: [Android][Removed] - Deleted obsolete native methods DevServerHelper.symbolicateStackTrace and DevServerHelper.openStackFrameCall Reviewed By: motiz88 Differential Revision: D44257731 fbshipit-source-id: 4a9f23d083a0ad1189f69ce0fd93c4275a708238
GijsWeterings
force-pushed
the
export-D44257731
branch
from
4ca6f90
to
27522cd
Compare
GijsWeterings
added a commit
to GijsWeterings/react-native
that referenced
this pull request
Apr 5, 2023
…StackFrameCall. (facebook#36652) Summary: Pull Request resolved: facebook#36652 I can't find any usecases for them, and JavaScript stack symbolication during development should probably just exclusively be done from the JS environment. Changelog: [Android][Removed] - Deleted obsolete native methods DevServerHelper.symbolicateStackTrace and DevServerHelper.openStackFrameCall Reviewed By: motiz88 Differential Revision: D44257731 fbshipit-source-id: c15c90dc48308aa55cee0665903675d60a2b7d34
GijsWeterings
force-pushed
the
export-D44257731
branch
from
27522cd
to
fa356c0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44257731 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D44257731 |
GijsWeterings
added a commit
to GijsWeterings/react-native
that referenced
this pull request
Apr 6, 2023
…StackFrameCall. (facebook#36652) Summary: Pull Request resolved: facebook#36652 I can't find any usecases for them, and JavaScript stack symbolication during development should probably just exclusively be done from the JS environment. Changelog: [Android][Removed] - Deleted obsolete native methods DevServerHelper.symbolicateStackTrace and DevServerHelper.openStackFrameCall Reviewed By: motiz88 Differential Revision: D44257731 fbshipit-source-id: 01691cc69a39ba980f0b2bb7675fe04783b17e12
GijsWeterings
force-pushed
the
export-D44257731
branch
from
fa356c0
to
c0c9bab
Compare
…StackFrameCall. (facebook#36652) Summary: Pull Request resolved: facebook#36652 I can't find any usecases for them, and JavaScript stack symbolication during development should probably just exclusively be done from the JS environment. Changelog: [Android][Removed] - Deleted obsolete native methods DevServerHelper.symbolicateStackTrace and DevServerHelper.openStackFrameCall Reviewed By: motiz88 Differential Revision: D44257731 fbshipit-source-id: 3f2e8ca35a488da3e81c21d7d5073f5443087b79
|
This pull request was exported from Phabricator. Differential Revision: D44257731 |
GijsWeterings
force-pushed
the
export-D44257731
branch
from
c0c9bab
to
8fe1aa7
Compare
|
This pull request has been merged in ad46bc6. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
…StackFrameCall. (facebook#36652) Summary: Pull Request resolved: facebook#36652 I can't find any usecases for them, and JavaScript stack symbolication during development should probably just exclusively be done from the JS environment. Changelog: [Android][Removed] - Deleted obsolete native methods DevServerHelper.symbolicateStackTrace and DevServerHelper.openStackFrameCall Reviewed By: motiz88 Differential Revision: D44257731 fbshipit-source-id: d090ecf413526c31d5fb028507d22fc7992e74b7
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…StackFrameCall. (facebook#36652) Summary: Pull Request resolved: facebook#36652 I can't find any usecases for them, and JavaScript stack symbolication during development should probably just exclusively be done from the JS environment. Changelog: [Android][Removed] - Deleted obsolete native methods DevServerHelper.symbolicateStackTrace and DevServerHelper.openStackFrameCall Reviewed By: motiz88 Differential Revision: D44257731 fbshipit-source-id: d090ecf413526c31d5fb028507d22fc7992e74b7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I can't find any usecases for these, and JavaScript stack symbolication during development should probably just exclusively be done from the JS environment.
Changelog:
[Android][Removed] - Deleted obsolete native methods DevServerHelper.symbolicateStackTrace and DevServerHelper.openStackFrameCall
Reviewed By: motiz88
Differential Revision: D44257731