Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Arguments.makeNativeObject to handle JavaOnlyMap and JavaOnlyArray #36743

Closed
wants to merge 4 commits into from

Conversation

genkikondo
Copy link
Contributor

Summary:
Changelog:
[Internal] - Modify Arguments.makeNativeObject to handle JavaOnlyMap and JavaOnlyArray

Reviewed By: mdvacca

Differential Revision: D44516305

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Mar 31, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44516305

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,571,027 +2,069
android hermes armeabi-v7a 7,885,415 +2,079
android hermes x86 9,052,947 +2,067
android hermes x86_64 8,907,973 +2,072
android jsc arm64-v8a 9,169,015 +1,375
android jsc armeabi-v7a 8,359,419 +1,370
android jsc x86 9,225,684 +1,364
android jsc x86_64 9,483,522 +1,367

Base commit: 6403363
Branch: main

genkikondo and others added 4 commits March 31, 2023 09:36
Differential Revision: D44279594

fbshipit-source-id: bbb0f1cfc177a51562c001355d591b5e84ec7439
Differential Revision: D44315336

fbshipit-source-id: 1b9b321b7652aaa9eb3f17728edc73f6f8936b75
Differential Revision: D44466563

fbshipit-source-id: 2cdbd427de5584c166bf82daa8440010d2bef62c
…rray (facebook#36743)

Summary:
Pull Request resolved: facebook#36743

Changelog:
[Internal] - Modify Arguments.makeNativeObject to handle JavaOnlyMap and JavaOnlyArray

Reviewed By: mdvacca

Differential Revision: D44516305

fbshipit-source-id: a8201b46d9469e8dee54bc1d97f78d12ec640d69
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44516305

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 80fb995.

jeongshin pushed a commit to jeongshin/react-native that referenced this pull request May 7, 2023
…rray (facebook#36743)

Summary:
Pull Request resolved: facebook#36743

Changelog:
[Internal] - Modify Arguments.makeNativeObject to handle JavaOnlyMap and JavaOnlyArray

Reviewed By: mdvacca

Differential Revision: D44516305

fbshipit-source-id: 22a4de4ae1b231078e7cd59cda3993b9f6343f7d
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
…rray (facebook#36743)

Summary:
Pull Request resolved: facebook#36743

Changelog:
[Internal] - Modify Arguments.makeNativeObject to handle JavaOnlyMap and JavaOnlyArray

Reviewed By: mdvacca

Differential Revision: D44516305

fbshipit-source-id: 22a4de4ae1b231078e7cd59cda3993b9f6343f7d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants