Bump TypeScript in template from 4.8.4 to 5.0.4

[leotm]

Summary:

https://devblogs.microsoft.com/typescript/announcing-typescript-5-0

Changelog:

[GENERAL] [CHANGED] - Bump TypeScript in template from 4.8.4 to 5.0.4 and ESLint pkgs from 8.19.0 to 8.38.0

Test Plan:

Everything builds and runs as expected

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,606,573	-16,428
android	hermes	armeabi-v7a	7,920,722	-15,638
android	hermes	x86	9,092,832	-16,815
android	hermes	x86_64	8,947,877	-16,797
android	jsc	arm64-v8a	9,173,833	-12,943
android	jsc	armeabi-v7a	8,365,493	-12,160
android	jsc	x86	9,231,488	-13,337
android	jsc	x86_64	9,490,181	-13,308

Base commit: 14b2b1c
Branch: main

[NickGerleman]

Do we also need to bump the version of the typescript eslint plug-in we bring in as well?

Previously, using TS 4.9 was enough to generate a warning with the resolved plug-in, but I don't recall how loose our constraints were, so maybe new apps will use a compatible version of the plug-in now.

Could we confirm linting a new project doesn't result in any warnings? Otherwise this LGTM.

[leotm]

great point ^ fixing the ESLint warning (to support TS 5) only needed bumping @typescript-eslint/parser to 5.55.0
(then other ESLint deps can be bumped alongside in fuller projects)

ref: https://github.com/typescript-eslint/typescript-eslint/releases/tag/v5.55.0

update TypeScript to 5.0 RC (typescript-eslint/typescript-eslint#6570) (36ef0e1)

[leotm]

can confirm no warnings in npx react-native@latest init RN0720RC1 --version 0.72.0-rc.1
after bumping to TS 5 https://github.com/leotm/RN0720RC1/commits/main

[leotm]

➜  RN0720RC1 git:(main) npm list @typescript-eslint/parser
RN0720RC1@0.0.1 /Users/leo/Documents/GitHub/RN0720RC1
└─┬ @react-native/eslint-config@0.72.1
  ├─┬ @typescript-eslint/eslint-plugin@5.57.1
  │ └── @typescript-eslint/parser@5.57.1 deduped
  └── @typescript-eslint/parser@5.57.1

👌

[kelset]

cc @lunaleaps

[kelset]

Hey @leotm when you say

Everything builds and runs as expected

what do you mean? What is the "everything" here? I'm surprised that bumping to 5.x didn't need any types changes 🤔

[NickGerleman]

➜ RN0720RC1 git:(main) npm list @typescript-eslint/parser
RN0720RC1@0.0.1 /Users/leo/Documents/GitHub/RN0720RC1
└─┬ @react-native/eslint-config@0.72.1
├─┬ @typescript-eslint/eslint-plugin@5.57.1
│ └── @typescript-eslint/parser@5.57.1 deduped
└── @typescript-eslint/parser@5.57.1

    
      
    

      
    

    
  
👌

This eslint config is also in the repo, so it can be bumped alongside this change.

[leotm]

my bad ^ was referring to

• CI passing (this PR)
• no TS compiler errors/warnings (demo'd in repro)
• no ESLint errors/warnings (demo'd in repro)

and gave android/ios a test run in repro

[leotm]

been monitoring TS 5 nightly/dev/rc in https://github.com/leotm/react-native-template-new-architecture past few mo

which types changes we expecting?

edit: oops worth noting, template above on 0.71.6 atm (not 0.72.0-rc.1 like the repro)

[leotm]

bumped @react-native/eslint-config from 0.72.1 to 0.73.0 in repro, still LGTM
https://github.com/leotm/RN0720RC1/commits/main

we're already on

react-native/packages/react-native/template/package.json

Line 20 in d49f1eb

"@react-native/eslint-config": "^0.73.0",

done in

• bump packages for 0.73 #36556 (so no need in current pr)

[leotm]

while we're at it bumped eslint from 8.19.0 to 8.38.0 in repro, still LGTM
https://github.com/leotm/RN0720RC1/commits/main

also done alongside in this pr, feel free to revert if needed

[kelset]

these types of bumps needs to be done repo wide, we can't misalign the template from the rest of the codebase.

[leotm]

sry bk from node congress berlin ^ makes sense like before and should be small w/o pkg lockfiles now

i'll bump remaining relevant pkgs and pray CI passes

[github-actions]

	Warnings
⚠️	🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 89b0d69

[kelset]

Headsup, for typescript, you are missing the root package.json - it's still at 4.x there.

[leotm]

ci/circleci: test_android_template-NewArch-Release-JSC
node ./scripts/template/initialize.js can't fetch pkgs -> can't make

ci/circleci: test_ios_template-NewArch-Release-WithoutFlipper-Hermes-StaticLibraries
bundle install && bundle exec pod install can't connect to github

ci/circleci: test_windows
yarn test FabricUIManager.getFabricUIManager()).measureLayout mistakenly called

[facebook-github-bot]

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@NickGerleman merged this pull request in d2e446d.