Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to disable the New Architecture inside RN Tester #36895

Closed
wants to merge 1 commit into from

Conversation

cortinico
Copy link
Contributor

Summary:
Currently RN-Tester build with the New Architecture hardcoded to true.
For testing is convenient to disable it at times so we can test how the app behaves in the old arch.

Changelog:
[Internal] [Changed] - Allow to disable the New Architecture inside RN Tester

Reviewed By: cipolleschi

Differential Revision: D44917566

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Apr 13, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44917566

Summary:
Pull Request resolved: facebook#36895

Currently RN-Tester build with the New Architecture hardcoded to true.
For testing is convenient to disable it at times so we can test how the app behaves in the old arch.

Changelog:
[Internal] [Changed] - Allow to disable the New Architecture inside RN Tester

Reviewed By: cipolleschi

Differential Revision: D44917566

fbshipit-source-id: 1f11412008d555de0c31556f9123bdb6fcdad556
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44917566

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,604,788 +0
android hermes armeabi-v7a 7,918,817 +0
android hermes x86 9,090,833 +0
android hermes x86_64 8,945,848 +0
android jsc arm64-v8a 9,174,204 +0
android jsc armeabi-v7a 8,365,854 +0
android jsc x86 9,231,847 +0
android jsc x86_64 9,490,545 +0

Base commit: 9f24df0
Branch: main

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Apr 13, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in acfe5e8.

jeongshin pushed a commit to jeongshin/react-native that referenced this pull request May 7, 2023
Summary:
Pull Request resolved: facebook#36895

Currently RN-Tester build with the New Architecture hardcoded to true.
For testing is convenient to disable it at times so we can test how the app behaves in the old arch.

Changelog:
[Internal] [Changed] - Allow to disable the New Architecture inside RN Tester

Reviewed By: cipolleschi

Differential Revision: D44917566

fbshipit-source-id: f1e6393e37bf6702677157b9577a26f0c4da0b86
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
Summary:
Pull Request resolved: facebook#36895

Currently RN-Tester build with the New Architecture hardcoded to true.
For testing is convenient to disable it at times so we can test how the app behaves in the old arch.

Changelog:
[Internal] [Changed] - Allow to disable the New Architecture inside RN Tester

Reviewed By: cipolleschi

Differential Revision: D44917566

fbshipit-source-id: f1e6393e37bf6702677157b9577a26f0c4da0b86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants