Replace usages of YGConfigSetUseLegacyStretchBehaviour #37093
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D45300631 |
Base commit: b3478cb |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 27, 2023
Summary: Pull Request resolved: facebook#37093 This replaces product usages of `YGConfigSetUseLegacyStretchBehaviour` with instead setting `YGErrataAll`, to opt out of future conformance fixes which may impact compatibility. We need to still audit C/C++ usage for where we should be applying `YGErrataClassic`, port this change to the RN desktop fork, then mark the function as deprecated (taking care to allow deprecated functions in the Yoga bindings to call deprecated C ABI functions without warning). Changelog: [Internal] Reviewed By: yungsters Differential Revision: D45300631 fbshipit-source-id: 50ae18fe20a30c3d607caba15b080cafad0ecc46
NickGerleman
force-pushed
the
export-D45300631
branch
from
c5027e1
to
4d8993e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45300631 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D45300631 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 27, 2023
Summary: Pull Request resolved: facebook#37093 This replaces product usages of `YGConfigSetUseLegacyStretchBehaviour` with instead setting `YGErrataAll`, to opt out of future conformance fixes which may impact compatibility. We need to still audit C/C++ usage for where we should be applying `YGErrataClassic`, port this change to the RN desktop fork, then mark the function as deprecated (taking care to allow deprecated functions in the Yoga bindings to call deprecated C ABI functions without warning). Changelog: [Internal] Reviewed By: yungsters Differential Revision: D45300631 fbshipit-source-id: 6828d6bf537591e1811d85122f162f9497771c4d
NickGerleman
force-pushed
the
export-D45300631
branch
from
4d8993e
to
957b5b5
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 27, 2023
Summary: Pull Request resolved: facebook#37093 This replaces product usages of `YGConfigSetUseLegacyStretchBehaviour` with instead setting `YGErrataAll`, to opt out of future conformance fixes which may impact compatibility. We need to still audit C/C++ usage for where we should be applying `YGErrataClassic`, port this change to the RN desktop fork, then mark the function as deprecated (taking care to allow deprecated functions in the Yoga bindings to call deprecated C ABI functions without warning). Changelog: [Internal] Reviewed By: yungsters Differential Revision: D45300631 fbshipit-source-id: f6289229414b7e10f42918cb557a421a82b3c02d
|
This pull request was exported from Phabricator. Differential Revision: D45300631 |
NickGerleman
force-pushed
the
export-D45300631
branch
from
957b5b5
to
a3fef74
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 27, 2023
Summary: Pull Request resolved: facebook#37093 This replaces product usages of `YGConfigSetUseLegacyStretchBehaviour` with instead setting `YGErrataAll`, to opt out of future conformance fixes which may impact compatibility. We need to still audit C/C++ usage for where we should be applying `YGErrataClassic`, port this change to the RN desktop fork, then mark the function as deprecated (taking care to allow deprecated functions in the Yoga bindings to call deprecated C ABI functions without warning). Changelog: [Internal] Reviewed By: yungsters Differential Revision: D45300631 fbshipit-source-id: a410ae9b22b463755e6d454f7fee80abd8b91f5e
NickGerleman
force-pushed
the
export-D45300631
branch
from
a3fef74
to
b336921
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45300631 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 27, 2023
Summary: Pull Request resolved: facebook#37093 This replaces product usages of `YGConfigSetUseLegacyStretchBehaviour` with instead setting `YGErrataAll`, to opt out of future conformance fixes which may impact compatibility. We need to still audit C/C++ usage for where we should be applying `YGErrataClassic`, port this change to the RN desktop fork, then mark the function as deprecated (taking care to allow deprecated functions in the Yoga bindings to call deprecated C ABI functions without warning). Changelog: [Internal] Reviewed By: yungsters Differential Revision: D45300631 fbshipit-source-id: 9178f9e175b6abeec7770cca0371230ce8f07b49
NickGerleman
force-pushed
the
export-D45300631
branch
from
b336921
to
863596b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45300631 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D45300631 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 27, 2023
Summary: Pull Request resolved: facebook#37093 This replaces product usages of `YGConfigSetUseLegacyStretchBehaviour` with instead setting `YGErrataAll`, to opt out of future conformance fixes which may impact compatibility. We need to still audit C/C++ usage for where we should be applying `YGErrataClassic`, port this change to the RN desktop fork, then mark the function as deprecated (taking care to allow deprecated functions in the Yoga bindings to call deprecated C ABI functions without warning). Changelog: [Internal] Reviewed By: yungsters Differential Revision: D45300631 fbshipit-source-id: 054be9d2cf52a9848ccbaf0e325519c77600e844
NickGerleman
force-pushed
the
export-D45300631
branch
from
863596b
to
9ca493b
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 27, 2023
Summary: Pull Request resolved: facebook#37093 This replaces product usages of `YGConfigSetUseLegacyStretchBehaviour` with instead setting `YGErrataAll`, to opt out of future conformance fixes which may impact compatibility. We need to still audit C/C++ usage for where we should be applying `YGErrataClassic`, port this change to the RN desktop fork, then mark the function as deprecated (taking care to allow deprecated functions in the Yoga bindings to call deprecated C ABI functions without warning). Changelog: [Internal] Reviewed By: yungsters Differential Revision: D45300631 fbshipit-source-id: 401ad047ad2a8466acb0f799844f7f32d033ffc0
NickGerleman
force-pushed
the
export-D45300631
branch
from
9ca493b
to
e1ac479
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45300631 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 27, 2023
Summary: Pull Request resolved: facebook#37093 This replaces product usages of `YGConfigSetUseLegacyStretchBehaviour` with instead setting `YGErrataAll`, to opt out of future conformance fixes which may impact compatibility. We need to still audit C/C++ usage for where we should be applying `YGErrataClassic`, port this change to the RN desktop fork, then mark the function as deprecated (taking care to allow deprecated functions in the Yoga bindings to call deprecated C ABI functions without warning). Changelog: [Internal] Reviewed By: yungsters Differential Revision: D45300631 fbshipit-source-id: 6c2ec36336764e5e7fe3cce55f1d32953afdac92
NickGerleman
force-pushed
the
export-D45300631
branch
from
e1ac479
to
ffcd273
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45300631 |
|
This pull request was exported from Phabricator. Differential Revision: D45300631 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D45300631 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 27, 2023
Summary: Pull Request resolved: facebook#37093 This replaces product usages of `YGConfigSetUseLegacyStretchBehaviour` with instead setting `YGErrataAll`, to opt out of future conformance fixes which may impact compatibility. We need to still audit C/C++ usage for where we should be applying `YGErrataClassic`, port this change to the RN desktop fork, then mark the function as deprecated (taking care to allow deprecated functions in the Yoga bindings to call deprecated C ABI functions without warning). Changelog: [Internal] Reviewed By: yungsters Differential Revision: D45300631 fbshipit-source-id: cff1981e63460ac7149c67d2a4d93e412393eea1
NickGerleman
force-pushed
the
export-D45300631
branch
from
db508e1
to
de0ffc9
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 27, 2023
Summary: Pull Request resolved: facebook#37093 This replaces product usages of `YGConfigSetUseLegacyStretchBehaviour` with instead setting `YGErrataAll`, to opt out of future conformance fixes which may impact compatibility. We need to still audit C/C++ usage for where we should be applying `YGErrataClassic`, port this change to the RN desktop fork, then mark the function as deprecated (taking care to allow deprecated functions in the Yoga bindings to call deprecated C ABI functions without warning). Changelog: [Internal] Reviewed By: yungsters Differential Revision: D45300631 fbshipit-source-id: 43e6504a311bd14a90691635524e50f787b19f9b
NickGerleman
force-pushed
the
export-D45300631
branch
from
de0ffc9
to
9ef530c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45300631 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 27, 2023
Summary: Pull Request resolved: facebook#37093 This replaces product usages of `YGConfigSetUseLegacyStretchBehaviour` with instead setting `YGErrataAll`, to opt out of future conformance fixes which may impact compatibility. We need to still audit C/C++ usage for where we should be applying `YGErrataClassic`, port this change to the RN desktop fork, then mark the function as deprecated (taking care to allow deprecated functions in the Yoga bindings to call deprecated C ABI functions without warning). Changelog: [Internal] Reviewed By: yungsters Differential Revision: D45300631 fbshipit-source-id: 7dec964c9e09c9ebcb59c5971af2fb8a139fe836
NickGerleman
force-pushed
the
export-D45300631
branch
from
9ef530c
to
e015f16
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45300631 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D45300631 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 27, 2023
Summary: Pull Request resolved: facebook#37093 This replaces product usages of `YGConfigSetUseLegacyStretchBehaviour` with instead setting `YGErrataAll`, to opt out of future conformance fixes which may impact compatibility. We need to still audit C/C++ usage for where we should be applying `YGErrataClassic`, port this change to the RN desktop fork, then mark the function as deprecated (taking care to allow deprecated functions in the Yoga bindings to call deprecated C ABI functions without warning). Changelog: [Internal] Reviewed By: yungsters Differential Revision: D45300631 fbshipit-source-id: 77069bfdbd3a2c516be920aaae5a45a5b063ea08
NickGerleman
force-pushed
the
export-D45300631
branch
from
e015f16
to
8d0dede
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 27, 2023
Summary: Pull Request resolved: facebook#37093 This replaces product usages of `YGConfigSetUseLegacyStretchBehaviour` with instead setting `YGErrataAll`, to opt out of future conformance fixes which may impact compatibility. We need to still audit C/C++ usage for where we should be applying `YGErrataClassic`, port this change to the RN desktop fork, then mark the function as deprecated (taking care to allow deprecated functions in the Yoga bindings to call deprecated C ABI functions without warning). Changelog: [Internal] Reviewed By: yungsters Differential Revision: D45300631 fbshipit-source-id: 4640f033b52f14db3f26dc682799a4c2c3235132
NickGerleman
force-pushed
the
export-D45300631
branch
from
8d0dede
to
14668e8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45300631 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 27, 2023
Summary: Pull Request resolved: facebook#37093 This replaces product usages of `YGConfigSetUseLegacyStretchBehaviour` with instead setting `YGErrataAll`, to opt out of future conformance fixes which may impact compatibility. We need to still audit C/C++ usage for where we should be applying `YGErrataClassic`, port this change to the RN desktop fork, then mark the function as deprecated (taking care to allow deprecated functions in the Yoga bindings to call deprecated C ABI functions without warning). Changelog: [Internal] Reviewed By: yungsters Differential Revision: D45300631 fbshipit-source-id: dbe8c82b3de677b9788878dc2b4fa2aaccabe156
NickGerleman
force-pushed
the
export-D45300631
branch
from
14668e8
to
9213f88
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45300631 |
Summary: This searches fbsource for the following strings corresponding to node or config creation using Yoga Java bindings. 1. `YogaNodeFactory.create` 2. `YogaConfigFactory.create` Apart from benchmarks/tests, thie leaves RN Paper, Litho and Native Templates. These are opted into compatibility with current Yoga behavior, using either `YogaErrata.CLASSIC`, or `YogaErrata.ALL` where `UseLegacyStretchBehaviour` is currently set. Differential Revision: https://internalfb.com/D45299721 fbshipit-source-id: 1814cb375ab0a51e9b0bbb58bd35aac4ce8e33c6
Summary: Now that our own usages are removed, mark this as deprecated to encourage users to move to the errata API. The same will be done to variants of this function on other platforms before releasing, and the functions will be removed after releasing. Differential Revision: D45300343 fbshipit-source-id: 11980ef895bc2bc8073fa6c10df4ccd11eb71c91
Summary: Pull Request resolved: facebook#37093 This replaces product usages of `YGConfigSetUseLegacyStretchBehaviour` with instead setting `YGErrataAll`, to opt out of future conformance fixes which may impact compatibility. We need to still audit C/C++ usage for where we should be applying `YGErrataClassic`, port this change to the RN desktop fork, then mark the function as deprecated (taking care to allow deprecated functions in the Yoga bindings to call deprecated C ABI functions without warning). Changelog: [Internal] Reviewed By: yungsters Differential Revision: D45300631 fbshipit-source-id: 97b5f4a70f77a590d77248f2a9d2b8fa6633004e
|
This pull request was exported from Phabricator. Differential Revision: D45300631 |
NickGerleman
force-pushed
the
export-D45300631
branch
from
9213f88
to
5fa19e4
Compare
|
This pull request has been merged in b0cf746. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: Pull Request resolved: facebook#37093 This replaces product usages of `YGConfigSetUseLegacyStretchBehaviour` with instead setting `YGErrataAll`, to opt out of future conformance fixes which may impact compatibility. We need to still audit C/C++ usage for where we should be applying `YGErrataClassic`, port this change to the RN desktop fork, then mark the function as deprecated (taking care to allow deprecated functions in the Yoga bindings to call deprecated C ABI functions without warning). Changelog: [Internal] Reviewed By: yungsters Differential Revision: D45300631 fbshipit-source-id: 9f94bdbbe7eda091adac016231083b2486c583d9
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#37093 This replaces product usages of `YGConfigSetUseLegacyStretchBehaviour` with instead setting `YGErrataAll`, to opt out of future conformance fixes which may impact compatibility. We need to still audit C/C++ usage for where we should be applying `YGErrataClassic`, port this change to the RN desktop fork, then mark the function as deprecated (taking care to allow deprecated functions in the Yoga bindings to call deprecated C ABI functions without warning). Changelog: [Internal] Reviewed By: yungsters Differential Revision: D45300631 fbshipit-source-id: 9f94bdbbe7eda091adac016231083b2486c583d9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This replaces product usages of
YGConfigSetUseLegacyStretchBehaviourwith instead settingYGErrataAll, to opt out of future conformance fixes which may impact compatibility.We need to still audit C/C++ usage for where we should be applying
YGErrataClassic, port this change to the RN desktop fork, then mark the function as deprecated (taking care to allow deprecated functions in the Yoga bindings to call deprecated C ABI functions without warning).Changelog: [Internal]
Differential Revision: D45300631