rename host preload -> start #37422
Closed
rename host preload -> start #37422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D45760583 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
May 13, 2023
Summary: Pull Request resolved: facebook#37422 Changelog: [Internal] in this simple change, i renamed the `preload` API, which triggers all the rct instance / javascript runtime creation to `start`. `preload` is a confusing API on the host because the host should be agnostic of when the timing to create its dependencies are, and the consumer should determine when initialization is lazy, early, etc. Reviewed By: cipolleschi Differential Revision: D45760583 fbshipit-source-id: b78b5daf191c0db3c11e0653629e8d0ceaa325f6
|
This pull request was exported from Phabricator. Differential Revision: D45760583 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
May 13, 2023
Summary: Pull Request resolved: facebook#37422 Changelog: [Internal] in this simple change, i renamed the `preload` API, which triggers all the rct instance / javascript runtime creation to `start`. `preload` is a confusing API on the host because the host should be agnostic of when the timing to create its dependencies are, and the consumer should determine when initialization is lazy, early, etc. Reviewed By: cipolleschi Differential Revision: D45760583 fbshipit-source-id: 18e5f3c65337af901177a08eaf1fbbba797741ea
|
This pull request was exported from Phabricator. Differential Revision: D45760583 |
Differential Revision: D45596321 fbshipit-source-id: 8ed8e8ba3f4e5683406da7eb1e8be7bf8ed504a0
Summary: Pull Request resolved: facebook#37422 Changelog: [Internal] in this simple change, i renamed the `preload` API, which triggers all the rct instance / javascript runtime creation to `start`. `preload` is a confusing API on the host because the host should be agnostic of when the timing to create its dependencies are, and the consumer should determine when initialization is lazy, early, etc. Reviewed By: cipolleschi Differential Revision: D45760583 fbshipit-source-id: b9ddfef98ce3e6b59fa116de64975cd391069570
|
This pull request was exported from Phabricator. Differential Revision: D45760583 |
Base commit: cd223d6 |
|
This pull request has been merged in 61335a1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
in this simple change, i renamed the
preloadAPI, which triggers all the rct instance / javascript runtime creation tostart.preloadis a confusing API on the host because the host should be agnostic of when the timing to create its dependencies are, and the consumer should determine when initialization is lazy, early, etc.Reviewed By: cipolleschi
Differential Revision: D45760583