Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Codegen 132] Add function emitMixedProp to parser-primitives #37608

Closed
wants to merge 1 commit into from

Conversation

siddarthkay
Copy link
Contributor

Summary:

[Codegen 132] This PR introduces emitMixedProp to parser-primitives and abstracts the logic out of typescript and parser events as requested on #34872

Changelog:

[Internal] [Changed] - Add emitMixedProp to parser-primitives and update usages.

Test Plan:

Run yarn jest react-native-codegen and ensure CI is green

Screenshot of tests passing locally:

Screenshot 2023-05-28 at 12 46 49 PM

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 28, 2023
@analysis-bot
Copy link

analysis-bot commented May 28, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,744,448 +2
android hermes armeabi-v7a 8,056,571 +5
android hermes x86 9,235,519 +6
android hermes x86_64 9,086,322 +4
android jsc arm64-v8a 9,307,022 +3
android jsc armeabi-v7a 8,496,525 +5
android jsc x86 9,369,009 +3
android jsc x86_64 9,623,917 +3

Base commit: 0af806e
Branch: main

Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! Thank you so much!

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in a497882.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants