fix(ios): fix pod install --project-directory=ios failing

[tido64]

Summary:

pod install --project-directory=ios currently fails when new arch is enabled: react-native-async-storage/async-storage#910

• Patch for 0.71: fix(ios): fix pod install --project-directory=ios failing #37993
• Patch for 0.72: fix(ios): fix pod install --project-directory=ios failing #37994

Changelog:

[IOS] [FIXED] - Fix pod install --project-directory=... when New Arch is enabled

Test Plan:

git clone https://github.com/react-native-async-storage/async-storage.git
cd async-storage
gh pr checkout 910
yarn
RCT_NEW_ARCH_ENABLED=1 pod install --project-directory=example/ios

[cipolleschi]

sorry that this is happening.. :(

1. CircleCI is still red
2. Do you mind adding a CircleCI test to keep this in check?

We can't really use the React Native repo to keep that checked, but we can create a job that prepare the template and rearranges the files so that we can invoke pod install with that variation.

what do you think?

[tido64]

sorry that this is happening.. :(

No worries, I'm sorry I didn't catch this earlier 😄

1. CircleCI is still red

Btw, did someone make changes to Danger bot? The changelog format should be correct but it's still complaining.

2. Do you mind adding a CircleCI test to keep this in check?

We can't really use the React Native repo to keep that checked, but we can create a job that prepare the template and rearranges the files so that we can invoke pod install with that variation.

what do you think?

Would it be enough to modify this slightly to run pod install from the parent directory:

react-native/.circleci/config.yml

Lines 907 to 908 in b3bb553

	bundle install
	bundle exec pod install

[kelset]

Btw, did someone make changes to Danger bot? The changelog format should be correct but it's still complaining.

It might be because you need the ":" in the title for "Changelog" -> "Changelog:"

[cipolleschi]

Would it be enough to modify this slightly to run pod install from the parent directory:
react-native/.circleci/config.yml
Lines 907 to 908 in b3bb553

        bundle install 
        bundle exec pod install

you mean with something like:

bundle install 
+ cd ..
-bundle exec pod install
+bundle exec pod install --project-directory=ios

We can try, but I am not sure it will work.
My understanding is that we need to run pod install from the same directory where the Podfile is. So we should actually move the podfile to the parent directory first. Am I right?

[tido64]

We can try, but I am not sure it will work. My understanding is that we need to run pod install from the same directory where the Podfile is. So we should actually move the podfile to the parent directory first. Am I right?

No, the whole purpose of --project-directory is to be able to point at the directory that contains Podfile. Let me try it in a draft PR.

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,958,132	+5
android	hermes	armeabi-v7a	8,219,318	+3
android	hermes	x86	9,471,795	+2
android	hermes	x86_64	9,314,263	+3
android	jsc	arm64-v8a	9,519,066	+3
android	jsc	armeabi-v7a	8,657,595	+2
android	jsc	x86	9,603,606	+1
android	jsc	x86_64	9,850,183	+3

Base commit: 7a2a327
Branch: main

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[github-actions]

This pull request was successfully merged by @tido64 in eb5f23c.

^{When will my fix make it into a release? | Upcoming Releases}