Decouple isTesting Platform flag from disabling/enabling animations when testing

[rshest]

Summary:

Changelog

[Internal] -

The internal Platform.isTesting is tightly coupled to animations being disabled, which in turn can lead to subtle problems in some of the corner cases:

• Since isTesting is force override to false on JS side in non-dev builds, it means that e2e tests, that would like to use release builds, are out of luck when animation disabling is desired
• Conversely, some of the e2e tests may actually rely on animations being enabled in order to work, which means they are also out of luck if trying to test a dev build
• Finally, we have cases of hybrid builds, which are build in release on native side, but also have __DEV__=true on the native side

To both cover the above scenarios, but also to be backwards compatible to all the existing once, this change introduces another flag, Platform.isDisableAnimations.

The way it works is:

• If it's not specified, the e2e tests behaviour will be exactly the same as before, since by default isDisableAnimations will be true when isTesting is true
• If it's specified and is equal to false, it means that animations will be still enabled, even if isTesting is true (for those e2e tests that rely on animations being enabled)
• If it's specified and is equal to 'true', it means that animations will be force disabled, no matter whether we test a release or a dev build

Note that this only specifies the JS side of things, defaulting Platform.isDisableAnimations to "not specified" (i.e. all the tests will behave as before).

Pulling it through for different platforms is done as a separate follow-up.

Differential Revision: D47516800

[github-actions]

	Warnings
⚠️	packages/react-native/Libraries/LayoutAnimation/LayoutAnimation.js#L13 - packages/react-native/Libraries/LayoutAnimation/LayoutAnimation.js line 13 – 'FabricUIManagerSpec' is defined but never used. (no-unused-vars)

Generated by 🚫 dangerJS against 36fd627

[facebook-github-bot]

This pull request was exported from Phabricator. Differential Revision: D47516800

[facebook-github-bot]

This pull request was exported from Phabricator. Differential Revision: D47516800

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,836,246	+31
android	hermes	armeabi-v7a	8,146,137	+24
android	hermes	x86	9,341,623	+22
android	hermes	x86_64	9,184,362	+27
android	jsc	arm64-v8a	9,448,107	+58
android	jsc	armeabi-v7a	8,629,863	+40
android	jsc	x86	9,530,780	+36
android	jsc	x86_64	9,773,988	+36

Base commit: 777934e
Branch: main

[github-actions]

This pull request was successfully merged by @rshest in 04ad34d.

^{When will my fix make it into a release? | Upcoming Releases}