Prevent check-for-reproducer action trigger on Umbrella and old issues #38664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Base commit: 6dc517a |
cortinico
approved these changes
Jul 28, 2023
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
approved these changes
Jul 28, 2023
|
@cortinico merged this pull request in 54d70cf. |
billnbell
pushed a commit
to billnbell/react-native
that referenced
this pull request
Jul 29, 2023
facebook#38664) Summary: This PR resolves problems with too spammy `check-for-reproducer` action triggering on very old and most prominently the Umbrella issues. Also, it brings back triggering on edited issues removed in facebook#38634 Related to facebook#35591 ## Changelog: [INTERNAL] [FIXED] - Prevent check-for-reproducer action trigger on Umbrella and old issues Pull Request resolved: facebook#38664 Test Plan: <img width="470" alt="image" src="https://github.com/facebook/react-native/assets/39658211/1d840145-1e4f-43c5-a3ea-bc16e61071ef"> Reviewed By: cipolleschi Differential Revision: D47868536 Pulled By: cortinico fbshipit-source-id: fd78c38145c76f3867a41439aee5d087f38c85d2
billnbell
pushed a commit
to billnbell/react-native
that referenced
this pull request
Jul 29, 2023
facebook#38664) Summary: This PR resolves problems with too spammy `check-for-reproducer` action triggering on very old and most prominently the Umbrella issues. Also, it brings back triggering on edited issues removed in facebook#38634 Related to facebook#35591 ## Changelog: [INTERNAL] [FIXED] - Prevent check-for-reproducer action trigger on Umbrella and old issues Pull Request resolved: facebook#38664 Test Plan: <img width="470" alt="image" src="https://github.com/facebook/react-native/assets/39658211/1d840145-1e4f-43c5-a3ea-bc16e61071ef"> Reviewed By: cipolleschi Differential Revision: D47868536 Pulled By: cortinico fbshipit-source-id: fd78c38145c76f3867a41439aee5d087f38c85d2
billnbell
pushed a commit
to billnbell/react-native
that referenced
this pull request
Jul 29, 2023
facebook#38664) Summary: This PR resolves problems with too spammy `check-for-reproducer` action triggering on very old and most prominently the Umbrella issues. Also, it brings back triggering on edited issues removed in facebook#38634 Related to facebook#35591 ## Changelog: [INTERNAL] [FIXED] - Prevent check-for-reproducer action trigger on Umbrella and old issues Pull Request resolved: facebook#38664 Test Plan: <img width="470" alt="image" src="https://github.com/facebook/react-native/assets/39658211/1d840145-1e4f-43c5-a3ea-bc16e61071ef"> Reviewed By: cipolleschi Differential Revision: D47868536 Pulled By: cortinico fbshipit-source-id: fd78c38145c76f3867a41439aee5d087f38c85d2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR resolves problems with too spammy
check-for-reproduceraction triggering on very old and most prominently the Umbrella issues.Also, it brings back triggering on edited issues removed in #38634
Related to #35591
Changelog:
[INTERNAL] [FIXED] - Prevent check-for-reproducer action trigger on Umbrella and old issues
Test Plan: