[Codegen-135] add getPaperTopLevelNameDeprecated to parsers
#38683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Base commit: 265f72f |
|
@cipolleschi @rshest : All checks pass and PR is ready for review |
rshest
requested changes
Jul 30, 2023
| @@ -414,4 +414,11 @@ export interface Parser { | |||
| * @returns: the properties of an object represented by a type annotation. | |||
| */ | |||
| getObjectProperties(typeAnnotation: $FlowFixMe): $FlowFixMe; | |||
|
|
|||
| /** | |||
| * Given a typeAnnotation return the properties of an object. | |||
There was a problem hiding this comment.
I imagine that's a copypaste?..
Could you please modify this so it actually does correspond to what the method does? :)
There was a problem hiding this comment.
oops, I forgot to update that 1st line, will fix! Thanks for the review :)
There was a problem hiding this comment.
updated the description @rshest
rshest
approved these changes
Jul 30, 2023
|
@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
[Codegen 135] This PR introduces
getPaperTopLevelNameDeprecatedto parser base class and abstracts the logic out of typescript and parser events as requested on #34872Changelog:
[Internal] [Changed] - Add
getPaperTopLevelNameDeprecatedto parser base class and update usages.Test Plan:
Run
yarn jest react-native-codegenlocally and ensure CI is greenScreenshot of test passing locally: