Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify test-e2e command in rn-tester-e2e pacakge #38701

Closed

Conversation

szymonrybczak
Copy link
Contributor

Summary:

This PR is small cleanup in scripts in rn-tester-e2e package, it creates unified script so that we can easily pass platform as an argument. Context: #36267 (comment)

Changelog:

[INTERNAL] [CHANGED] - Unify test-e2e command in rn-tester-e2e package

Test Plan:

CI Green ✅

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Jul 31, 2023
@analysis-bot
Copy link

analysis-bot commented Jul 31, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,889,842 -264
android hermes armeabi-v7a 7,939,948 +1,833
android hermes x86 9,287,275 -490
android hermes x86_64 9,191,472 +2,053
android jsc arm64-v8a 9,479,679 +1,597
android jsc armeabi-v7a 8,422,764 +3,682
android jsc x86 9,463,255 +1,369
android jsc x86_64 9,780,163 +3,906

Base commit: 5eaf28b
Branch: main

@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @szymonrybczak, thank you a lot for this PR.

I left a couple of comments to improve code organization and relieve maintenance burden. Let me know what do you think!

@@ -0,0 +1,13 @@
#!/bin/bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given that this is a new script. Can we have it in JS instead of in bash?

This will make it more portable and JS is easier to read and reason about. Also, we have linters and formatters for it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also... can we create a folder into scripts/e2e where we put these scripts? This will keep the folder more organized.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea, changed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also... can we create a folder into scripts/e2e where we put these scripts? This will keep the folder more organized.

Would you like me to move all scripts related to running e2e to this folder?

Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the PR!

@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

This pull request was successfully merged by @szymonrybczak in 378aa72.

When will my fix make it into a release? | Upcoming Releases

@github-actions github-actions bot added the Merged This PR has been merged. label Aug 2, 2023
@szymonrybczak szymonrybczak deleted the chore/unify-test-e2e-command branch August 2, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants