Cache ScrollView content length before calling scrollToIndex
#38736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47978635 |
Base commit: 0a1c2ef |
…ook#38736) Summary: Pull Request resolved: facebook#38736 `scrollToIndex` relies on cached layout information, so we should cache the results from `onContentSizeChange` before attempting the scroll. Otherwise we will fail to scroll in RTL. Changelog: [General][Fixed] Cache ScrollView content length before calling `scrollToIndex` Reviewed By: lenaic Differential Revision: D47978635 fbshipit-source-id: 8a9952cf5146a10ce38465ccb9922e531a772287
NickGerleman
force-pushed
the
export-D47978635
branch
from
d45ab58
to
0b2cdae
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47978635 |
|
This pull request was successfully merged by @NickGerleman in 33d6da0. When will my fix make it into a release? | Upcoming Releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
scrollToIndexrelies on cached layout information, so we should cache the results fromonContentSizeChangebefore attempting the scroll. Otherwise we will fail to scroll in RTL.Changelog:
[General][Fixed] Cache ScrollView content length before calling
scrollToIndexDifferential Revision: D47978635