Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Codegen-119] add emitBuildEventSchema to parser commons #38810

Closed
wants to merge 1 commit into from

Conversation

siddarthkay
Copy link
Contributor

Summary:

[Codegen 119] This PR introduces emitBuildEventSchema to parser commons and abstracts the logic out of typescript and parser events as requested on #34872

Changelog:

[Internal] [Changed] - Add emitBuildEventSchema to parser commons and update usages.

Test Plan:

Run yarn jest react-native-codegen locally and ensure CI is green

Screenshot of test passing locally:

Screenshot 2023-08-07 at 8 03 49 AM

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Aug 7, 2023
@siddarthkay siddarthkay force-pushed the codegen-119 branch 2 times, most recently from f801d21 to 9404c99 Compare August 7, 2023 02:58
@analysis-bot
Copy link

analysis-bot commented Aug 7, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,892,947 +4
android hermes armeabi-v7a 7,941,684 +3
android hermes x86 9,290,709 +3
android hermes x86_64 9,192,358 +5
android jsc arm64-v8a 9,485,540 +1
android jsc armeabi-v7a 8,427,236 +4
android jsc x86 9,469,459 +3
android jsc x86_64 9,783,836 +2

Base commit: 408dd81
Branch: main

@siddarthkay
Copy link
Contributor Author

@cipolleschi @rshest : All checks have passed and this PR is now ready for review.

@cipolleschi
Copy link
Contributor

Hi @siddarthkay! Thanks for your work. I think that there could be some conflicts between this and the work don in Coegen 112. Could you rebase, fix those conflicts and verify that everything is fine?

@siddarthkay
Copy link
Contributor Author

@cipolleschi : of-course, I'll rebase.

@siddarthkay
Copy link
Contributor Author

Hi @cipolleschi : all checks pass after rebasing, PR looks good 👍🏻

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

This pull request was successfully merged by @siddarthkay in 1d87279.

When will my fix make it into a release? | Upcoming Releases

@github-actions github-actions bot added the Merged This PR has been merged. label Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants