Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(releases): improve bump oss script to allow less human errors (71 edition) #38890

Merged
merged 1 commit into from
Aug 16, 2023

Commits on Aug 9, 2023

  1. chore(releases): improve bump oss script to allow less human errors (#…

    …38666)
    
    Summary:
    One of the limitations of the existing flow for the release crew is that they need to manually remember to publish all the other packages in the monorepo ahead of a new patch release - this PR modifies the logic for the bump-oss-version script (and makes it available via yarn) so that it will not run if:
    * there are git changes lying around
    * if some of the packages need a new release
    
    it required a bit of refactoring to extract some portions of the logic from the bump-all-package-versions script, but I think the end result is pretty decent.
    
    ## Changelog:
    
    <!-- Help reviewers and the release process by writing your own changelog entry.
    
    Pick one each for the category and type tags:
    
    For more details, see:
    https://reactnative.dev/contributing/changelogs-in-pull-requests
    -->
    
    [INTERNAL] [CHANGED] - improve bump oss script to allow less human errors
    
    Pull Request resolved: #38666
    
    Test Plan:
    * checkout this branch
    * comment L54 of bump-oss-version.js (to remove the check on the branch name)
    * run `yarn bump-all-updated-packages`, verify that it works and that it detects that some packages have unreleased code
    * run `yarn bump-oss-version -t asd -v asd` (the "fake" parameters are needed to pass the yargs check), verify that it will throw an error because it finds a package that has unreleased code
    
    Reviewed By: mdvacca
    
    Differential Revision: D48156963
    
    Pulled By: cortinico
    
    fbshipit-source-id: 2473ad5a84578c5236c905fd9aa9a88113fe8d22
    
    # Conflicts:
    #	scripts/publish-npm.js
    
    re-add the file
    
    nit
    
    # Conflicts:
    #	package.json
    kelset committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    9157841 View commit details
    Browse the repository at this point in the history