Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LOCAL] Fix Ruby Tests for 0.72 #38919

Closed
wants to merge 5 commits into from
Closed

[LOCAL] Fix Ruby Tests for 0.72 #38919

wants to merge 5 commits into from

Conversation

cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Aug 10, 2023 •
edited
Loading

Summary:

Fix Ruby tests for 0.72 release

Changelog:

[IOS] [FIXED] - Fix Ruby tests for 0.72 release

Test Plan:

Tested locally by:

git checkout 0.72-stable
git fetch && git pull origin 0.72-stable
cd packages/react-native/scripts 
./run_ruby_tests.sh

Screenshot 2023-08-10 at 10 07 00

billnbell and others added 5 commits August 8, 2023 10:26
@billnbell @fortmarek
Update new_architecture.rb for React-ImageManager (#38247)
1761aea 
Summary:
This added React-ImageManager to the use_frameworks! - a lot of rpm modules podspec need this.

bypass-github-export-checks

[iOS] [FIXED] - Add React-ImageManager path to work with use_frameworks!

For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests

Pull Request resolved: #38247

Test Plan: Should not be breaking - it will add to the header_search_paths React-ImageManager

Reviewed By: dmytrorykun

Differential Revision: D47593749

Pulled By: cipolleschi

fbshipit-source-id: a66e90707e5fa73573deab1f04e8d8693869a90c
Fix missing Platform in VirtualizedList
abedc58
@cortinico
[LOCAL] Fabric Interop - Properly dispatch integer commands (#38527) (#…
3386bb4 
…38835)

resolved: #38527
@michalmaka
Restore checking shadow tree commit cancellation after commit hook ex…
c7f0261 
…ecution (#38715)

Summary:
Hello! This PR is a fix for one merged some time ago (#36216). In the PR check for `nullptr` value of `newRootShadowNode` just after performing commit hooks was overlooked. This PR restores previous behaviour of conditional commit cancellation after commit hook execution.

## Changelog:

[INTERNAL] [FIXED] - Restore checking shadow tree commit cancellation after commit hook execution

Pull Request resolved: #38715

Test Plan: Just register a commit hook that return `nullptr`. In that case current code crashes due to `nullptr` dereference.

Reviewed By: sammy-SC

Differential Revision: D47972245

Pulled By: ryancat

fbshipit-source-id: 7599ad11ed4b2dcaf25e53f676ec4530e37410d5
@cipolleschi
[LOCAL] Fix Ruby Tests for 0.72
db81d8f
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Aug 10, 2023
@cipolleschi cipolleschi changed the base branch from main to 0.72-stable August 10, 2023 09:06
@cipolleschi cipolleschi marked this pull request as ready for review August 10, 2023 09:07
@cortinico cortinico deleted the cipolleschi/fix-ruby-test-072 branch June 10, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huntie huntie huntie approved these changes

@lunaleaps lunaleaps Awaiting requested review from lunaleaps

@Titozzz Titozzz Awaiting requested review from Titozzz

@fortmarek fortmarek Awaiting requested review from fortmarek

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cipolleschi @huntie @facebook-github-bot @billnbell @cortinico @michalmaka