Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use runtime scheduler in the old architecture #39057

Closed
wants to merge 4 commits into from
Closed

Use runtime scheduler in the old architecture #39057

wants to merge 4 commits into from

Conversation

cipolleschi
Copy link
Contributor

Summary:

Changelog:

[iOS][Changed] - Use the runtime scheduler in the old Architecture

Facebook

Differential Revision: D48430129

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Aug 17, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48430129

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48430129

cipolleschi added a commit to cipolleschi/react-native that referenced this pull request Aug 17, 2023
@cipolleschi @facebook-github-bot
Use runtime scheduler in the old architecture (facebook#39057)
7e1d56d 
Summary:
Pull Request resolved: facebook#39057

## Changelog:
[iOS][Changed] - Use the runtime scheduler in the old Architecture

## Facebook

Differential Revision: D48430129

fbshipit-source-id: b13259282fda33c68a467045de75b0e98d380b80
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48430129

cipolleschi added a commit to cipolleschi/react-native that referenced this pull request Aug 17, 2023
@cipolleschi @facebook-github-bot
Use runtime scheduler in the old architecture (facebook#39057)
afdc318 
Summary:
Pull Request resolved: facebook#39057

## Changelog:
[iOS][Changed] - Use the runtime scheduler in the old Architecture

## Facebook

Differential Revision: D48430129

fbshipit-source-id: 328b273848c606a9e565087c168316171afbbe43
@analysis-bot
Copy link

analysis-bot commented Aug 17, 2023 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,965,565 +9
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,554,383 -43
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 45f7e11
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48430129

cipolleschi added a commit to cipolleschi/react-native that referenced this pull request Aug 17, 2023
@cipolleschi @facebook-github-bot
Use runtime scheduler in the old architecture (facebook#39057)
c307365 
Summary:
Pull Request resolved: facebook#39057

## Changelog:
[iOS][Changed] - Use the runtime scheduler in the old Architecture

## Facebook

Differential Revision: D48430129

fbshipit-source-id: 730a784a3faefd55d18d4e437219d25425af9d00
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48430129

cipolleschi added a commit to cipolleschi/react-native that referenced this pull request Aug 17, 2023
@cipolleschi @facebook-github-bot
Use runtime scheduler in the old architecture (facebook#39057)
6e17e19 
Summary:
Pull Request resolved: facebook#39057

## Changelog:
[iOS][Changed] - Use the runtime scheduler in the old Architecture

## Facebook

Differential Revision: D48430129

fbshipit-source-id: 3679b142bd44228ff437379d1329599a826ad38b
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48430129

cipolleschi added a commit to cipolleschi/react-native that referenced this pull request Aug 17, 2023
@cipolleschi @facebook-github-bot
Use runtime scheduler in the old architecture (facebook#39057)
560b666 
Summary:
Pull Request resolved: facebook#39057

## Changelog:
[iOS][Changed] - Use the runtime scheduler in the old Architecture

## Facebook

Differential Revision: D48430129

fbshipit-source-id: a6a57edb2a17fb0ece605bf636750724cc438b2b
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48430129

cipolleschi added a commit to cipolleschi/react-native that referenced this pull request Aug 17, 2023
@cipolleschi @facebook-github-bot
Use runtime scheduler in the old architecture (facebook#39057)
19935a6 
Summary:
Pull Request resolved: facebook#39057

## Changelog:
[iOS][Changed] - Use the runtime scheduler in the old Architecture

## Facebook

Differential Revision: D48430129

fbshipit-source-id: 05798972601c53324e25420812668af7cfacbddc
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48430129

cipolleschi added a commit to cipolleschi/react-native that referenced this pull request Aug 17, 2023
@cipolleschi @facebook-github-bot
Use runtime scheduler in the old architecture (facebook#39057)
abf6619 
Summary:
Pull Request resolved: facebook#39057

## Changelog:
[iOS][Changed] - Use the runtime scheduler in the old Architecture

## Facebook

Differential Revision: D48430129

fbshipit-source-id: 6d7b67f6c9d861e1160619e6174cf55d3a1bd279
cipolleschi pushed a commit to cipolleschi/react-native that referenced this pull request Aug 18, 2023
@facebook-github-bot
Use runtime scheduler in the old architecture (facebook#39057)
bd063fa 
Summary:
Pull Request resolved: facebook#39057

## Changelog:
[iOS][Changed] - Use the runtime scheduler in the old Architecture

## Facebook

Differential Revision: https://internalfb.com/D48430129

fbshipit-source-id: ca5f38cc1342e4bbc13c2c5dac36e2f0a2386df7
cipolleschi pushed a commit to cipolleschi/react-native that referenced this pull request Aug 18, 2023
@facebook-github-bot
Use runtime scheduler in the old architecture (facebook#39057)
c33e19a 
Summary:
Pull Request resolved: facebook#39057

## Changelog:
[iOS][Changed] - Use the runtime scheduler in the old Architecture

## Facebook

Differential Revision: https://internalfb.com/D48430129

fbshipit-source-id: 0be3f2e712538975f1a34f859a4f05d440e20d76
cipolleschi pushed a commit to cipolleschi/react-native that referenced this pull request Aug 18, 2023
@facebook-github-bot
Use runtime scheduler in the old architecture (facebook#39057)
6c337d5 
Summary:
Pull Request resolved: facebook#39057

## Changelog:
[iOS][Changed] - Use the runtime scheduler in the old Architecture

## Facebook

Differential Revision: https://internalfb.com/D48430129

fbshipit-source-id: 6755c5601feaccab64a4281cb64fb9f647bcfe84
cipolleschi added a commit to cipolleschi/react-native that referenced this pull request Aug 23, 2023
@cipolleschi @facebook-github-bot
Use runtime scheduler in the old architecture (facebook#39057)
c0cd2c4 
Summary:
Pull Request resolved: facebook#39057

## Changelog:
[iOS][Changed] - Use the runtime scheduler in the old Architecture

## Facebook

Reviewed By: sammy-SC

Differential Revision: D48430129

fbshipit-source-id: bfa7cf36a31ac3a1f1c4c6d8afe10e8ab45e462f
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48430129

cipolleschi added a commit to cipolleschi/react-native that referenced this pull request Aug 24, 2023
@cipolleschi @facebook-github-bot
Use runtime scheduler in the old architecture (facebook#39057)
2fd865d 
Summary:
Pull Request resolved: facebook#39057

## Changelog:
[iOS][Changed] - Use the runtime scheduler in the old Architecture

## Facebook

Reviewed By: sammy-SC

Differential Revision: D48430129

fbshipit-source-id: 8f81eb0b774fad6e95ea1719cdfa0aeb27df075b
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48430129

cipolleschi added a commit to cipolleschi/react-native that referenced this pull request Aug 24, 2023
@cipolleschi @facebook-github-bot
Use runtime scheduler in the old architecture (facebook#39057)
56641f1 
Summary:
Pull Request resolved: facebook#39057

## Changelog:
[iOS][Changed] - Use the runtime scheduler in the old Architecture

## Facebook

Reviewed By: sammy-SC

Differential Revision: D48430129

fbshipit-source-id: 4e7fa0dd568e279b26e124a2e9542d0026aecdf0
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48430129

cipolleschi added a commit to cipolleschi/react-native that referenced this pull request Aug 24, 2023
@cipolleschi @facebook-github-bot
Use runtime scheduler in the old architecture (facebook#39057)
3fc7627 
Summary:
Pull Request resolved: facebook#39057

## Changelog:
[iOS][Changed] - Use the runtime scheduler in the old Architecture

## Facebook

Reviewed By: sammy-SC

Differential Revision: D48430129

fbshipit-source-id: ea7c90e83c1adcedf8f5952f7b978cdc022d0b36
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48430129

cipolleschi added a commit to cipolleschi/react-native that referenced this pull request Aug 24, 2023
@cipolleschi @facebook-github-bot
Use runtime scheduler in the old architecture (facebook#39057)
57a6258 
Summary:
Pull Request resolved: facebook#39057

## Changelog:
[iOS][Changed] - Use the runtime scheduler in the old Architecture

## Facebook

bypass-github-export-checks

Reviewed By: sammy-SC

Differential Revision: D48430129

fbshipit-source-id: 01a8df09c1a04b470cd1450decffbf6af394f8c5
Riccardo Cipolleschi and others added 4 commits August 24, 2023 05:29
@facebook-github-bot
Remove unused imports
771106c 
Summary:
## Changelog:
[Internal] - Remove unused imports

## Facebook:

Differential Revision: https://internalfb.com/D48429794

fbshipit-source-id: f03d6bc7f87469d537219999f9a494c2051cce18
@facebook-github-bot
Reduce header dependencies in RuntimeScheduler (facebook#39056)
7ca3ad0 
Summary:
Pull Request resolved: facebook#39056

## Changelog:
[Internal] - Reduce header dependencies in RuntimeScheduler

## Facebook:

Differential Revision: https://internalfb.com/D48429842

fbshipit-source-id: b6d544ffcf2d23b95e06c78492bf3a382666d1c9
@facebook-github-bot
Add RuntimeScheduler dependency properly
30553d1 
Summary:
## Changelog:
[iOS][Changed] - Extract RuntimeScheduler as separate cocoapod dependency

## Facebook:

Differential Revision: https://internalfb.com/D48429964

fbshipit-source-id: 63240bb360de84fa4bba3b43d1ea5fa78bdde1f5
@cipolleschi @facebook-github-bot
Use runtime scheduler in the old architecture (facebook#39057)
d38ffb5 
Summary:
Pull Request resolved: facebook#39057

## Changelog:
[iOS][Changed] - Use the runtime scheduler in the old Architecture

## Facebook

bypass-github-export-checks

Reviewed By: sammy-SC

Differential Revision: D48430129

fbshipit-source-id: 7e3edda9676c4f37939cdec3ff412115ecaf69cc
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48430129

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Aug 24, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 2692f20.

@touchmarine touchmarine mentioned this pull request Oct 7, 2023
Closed
2 tasks
@gabrieldonadel gabrieldonadel mentioned this pull request Nov 1, 2023
Closed
facebook-github-bot pushed a commit that referenced this pull request Nov 1, 2023
@gabrieldonadel @facebook-github-bot
Fix ios pod post_install logic for detecting if fabric is enabled (#4…
0f8a83e 
…1284)

Summary:
There is a problem in the way that we check if Fabric is enabled inside `react_native_post_install`.

https://github.com/facebook/react-native/blob/899e7cdb55197fc17a96a93af4f8bcc7519553c2/packages/react-native/scripts/react_native_pods.rb#L239

We're determining if fabric is enabled by checking if the `React-Fabric pod `is present, but since we always call `setup_fabric!(:react_native_path => prefix)`  (#39057) inside `use_react_native` the `React-Fabric` pod is always present causing the `-DRN_FABRIC_ENABLED` flag to always be added to `project.pbxproj` even if the new arch is disabled.

## Changelog:

[IOS] [FIXED] - Fix ios pod post_install logic for detecting if fabric is enabled

Pull Request resolved: #41284

Test Plan: Run `use_react_native!(fabric => false)` should not add the `-DRN_FABRIC_ENABLED` flag to `project.pbxproj`

Reviewed By: fkgozali

Differential Revision: D50896487

Pulled By: cipolleschi

fbshipit-source-id: 78154407ce52b09fd3a317b7dc64bd4bba56363e
douglowder pushed a commit to react-native-tvos/react-native-tvos that referenced this pull request Nov 2, 2023
@gabrieldonadel @douglowder
Fix ios pod post_install logic for detecting if fabric is enabled (#4…
d01dec7 
…1284)

Summary:
There is a problem in the way that we check if Fabric is enabled inside `react_native_post_install`.

https://github.com/facebook/react-native/blob/899e7cdb55197fc17a96a93af4f8bcc7519553c2/packages/react-native/scripts/react_native_pods.rb#L239

We're determining if fabric is enabled by checking if the `React-Fabric pod `is present, but since we always call `setup_fabric!(:react_native_path => prefix)`  (facebook/react-native#39057) inside `use_react_native` the `React-Fabric` pod is always present causing the `-DRN_FABRIC_ENABLED` flag to always be added to `project.pbxproj` even if the new arch is disabled.

[IOS] [FIXED] - Fix ios pod post_install logic for detecting if fabric is enabled

Pull Request resolved: facebook/react-native#41284

Test Plan: Run `use_react_native!(fabric => false)` should not add the `-DRN_FABRIC_ENABLED` flag to `project.pbxproj`

Reviewed By: fkgozali

Differential Revision: D50896487

Pulled By: cipolleschi

fbshipit-source-id: 78154407ce52b09fd3a317b7dc64bd4bba56363e
lunaleaps pushed a commit that referenced this pull request Nov 3, 2023
@gabrieldonadel
Fix ios pod post_install logic for detecting if fabric is enabled (#4…
8414427 
…1284)

Summary:
There is a problem in the way that we check if Fabric is enabled inside `react_native_post_install`.

https://github.com/facebook/react-native/blob/899e7cdb55197fc17a96a93af4f8bcc7519553c2/packages/react-native/scripts/react_native_pods.rb#L239

We're determining if fabric is enabled by checking if the `React-Fabric pod `is present, but since we always call `setup_fabric!(:react_native_path => prefix)`  (#39057) inside `use_react_native` the `React-Fabric` pod is always present causing the `-DRN_FABRIC_ENABLED` flag to always be added to `project.pbxproj` even if the new arch is disabled.

[IOS] [FIXED] - Fix ios pod post_install logic for detecting if fabric is enabled

Pull Request resolved: #41284

Test Plan: Run `use_react_native!(fabric => false)` should not add the `-DRN_FABRIC_ENABLED` flag to `project.pbxproj`

Reviewed By: fkgozali

Differential Revision: D50896487

Pulled By: cipolleschi

fbshipit-source-id: 78154407ce52b09fd3a317b7dc64bd4bba56363e
Othinn pushed a commit to Othinn/react-native that referenced this pull request Jan 9, 2024
@gabrieldonadel @Othinn
Fix ios pod post_install logic for detecting if fabric is enabled (fa…
37b571c 
…cebook#41284)

Summary:
There is a problem in the way that we check if Fabric is enabled inside `react_native_post_install`.

https://github.com/facebook/react-native/blob/899e7cdb55197fc17a96a93af4f8bcc7519553c2/packages/react-native/scripts/react_native_pods.rb#L239

We're determining if fabric is enabled by checking if the `React-Fabric pod `is present, but since we always call `setup_fabric!(:react_native_path => prefix)`  (facebook#39057) inside `use_react_native` the `React-Fabric` pod is always present causing the `-DRN_FABRIC_ENABLED` flag to always be added to `project.pbxproj` even if the new arch is disabled.

## Changelog:

[IOS] [FIXED] - Fix ios pod post_install logic for detecting if fabric is enabled

Pull Request resolved: facebook#41284

Test Plan: Run `use_react_native!(fabric => false)` should not add the `-DRN_FABRIC_ENABLED` flag to `project.pbxproj`

Reviewed By: fkgozali

Differential Revision: D50896487

Pulled By: cipolleschi

fbshipit-source-id: 78154407ce52b09fd3a317b7dc64bd4bba56363e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cipolleschi @facebook-github-bot @analysis-bot