Unblock yarn android on main
#39413
Closed
Unblock yarn android on main
#39413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49190626 |
Base commit: daa2bc7 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Sep 12, 2023
Summary: `yarn android` on main is currently broken due to the CLI attempting to search for the manifest inside the src/androidTest folder. This fixes it by specifying the exact path of the Android Manifest. The fix to the CLI is also pending to prevent the CLI from searching inside test folders. Fix for the CLI is here: - react-native-community/cli#2075 Changelog: [Internal] [Changed] - Unblock `yarn android` on main Reviewed By: huntie Differential Revision: D49190626
cortinico
force-pushed
the
export-D49190626
branch
from
1038a1a
to
fa13cc7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49190626 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D49190626 |
cortinico
force-pushed
the
export-D49190626
branch
from
fa13cc7
to
f9cd582
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Sep 13, 2023
Summary: `yarn android` on main is currently broken due to the CLI attempting to search for the manifest inside the src/androidTest folder. This fixes it by specifying the exact path of the Android Manifest. The fix to the CLI is also pending to prevent the CLI from searching inside test folders. Fix for the CLI is here: - react-native-community/cli#2075 Changelog: [Internal] [Changed] - Unblock `yarn android` on main Reviewed By: huntie Differential Revision: D49190626
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Sep 13, 2023
Summary: `yarn android` on main is currently broken due to the CLI attempting to search for the manifest inside the src/androidTest folder. This fixes it by specifying the exact path of the Android Manifest. The fix to the CLI is also pending to prevent the CLI from searching inside test folders. Fix for the CLI is here: - react-native-community/cli#2075 Changelog: [Internal] [Changed] - Unblock `yarn android` on main Reviewed By: huntie Differential Revision: D49190626
cortinico
force-pushed
the
export-D49190626
branch
from
f9cd582
to
4fa55d1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49190626 |
Summary: `yarn android` on main is currently broken due to the CLI attempting to search for the manifest inside the src/androidTest folder. This fixes it by specifying the exact path of the Android Manifest. The fix to the CLI is also pending to prevent the CLI from searching inside test folders. Fix for the CLI is here: - react-native-community/cli#2075 Changelog: [Internal] [Changed] - Unblock `yarn android` on main Reviewed By: huntie Differential Revision: D49190626
cortinico
force-pushed
the
export-D49190626
branch
from
4fa55d1
to
de97586
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49190626 |
|
This pull request has been merged in b15a2c3. |
adamaveray
added a commit
to adamaveray/react-native
that referenced
this pull request
Sep 13, 2023
* main: (1012 commits) Add simple constructor for JSError (facebook#39415) Breaking: per-node pointScaleFactor (facebook#39403) Implement "tickleJS" for Hermes (facebook#39289) Add thread idle indicator (facebook#39206) Unblock `yarn android` on main (facebook#39413) Remove Codegen buck-oss scripts as they're unused (facebook#39422) Immediately dispatch events to the shared C++ infrastructure to support interruptability (facebook#39380) Fix race condition in Binding::reportMount (facebook#39420) Clone free state progression (facebook#39357) fix: return the correct default trait collection (facebook#38214) Read the React Native version and set the new arch flag properly (facebook#39388) Deprecate default_flags in Podfile (facebook#39389) Create Helper to read the package.json from Cocoapods (facebook#39390) Create helper to enforce the New Arch enabled for double released (facebook#39387) Remove layoutContext Drilling (facebook#39401) Remove JNI Binding usage of layoutContext (facebook#39402) Extract isBaselineLayout() (facebook#39400) Refactor and separate layout affected nodes react marker (facebook#39249) Bump AGP to 8.1.1 (facebook#39392) Fix broken Gradle Sync when opening the project with Android Studio (facebook#39412) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
yarn androidon main is currently broken due to the CLI attempting to search for the manifest inside the src/androidTest folder.This fixes it by specifying the exact path of the Android Manifest.
The fix to the CLI is also pending to prevent the CLI from searching inside test folders.
Fix for the CLI is here:
Changelog:
[Internal] [Changed] - Unblock
yarn androidon mainDifferential Revision: D49190626