Fix podspecs building with C++ 14 #39464
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49303081 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D49303081 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 15, 2023
Summary: Pull Request resolved: facebook#39464 We currently have 854 warnings emitted due to nested namespaces being a C++ 17 extension lol. This sets the standard explicitly to C++ 20 in the specs emitting the warnings (mostly RCT-Text). It is undesirable that we add hundreds of warnings to the CocoaPods build without signal. Our Buck build and OSS Android build both treat warnings as errors. But... that is for another day. Changelog: [Intenrnal] Reviewed By: cortinico Differential Revision: D49303081 fbshipit-source-id: 786d4fcdf4871433c3e0dbaec2cf02eef9e08978
NickGerleman
force-pushed
the
export-D49303081
branch
from
1b50f27
to
db8379d
Compare
Base commit: e513a50 |
Summary: We currently have 854 warnings emitted due to nested namespaces being a C++ 17 extension lol. This sets the standard explicitly to C++ 20 in the specs emitting the warnings (mostly RCT-Text). It is undesirable that we add hundreds of warnings to the CocoaPods build without signal. Our Buck build and OSS Android build both treat warnings as errors. But... that is for another day. Changelog: [Intenrnal] Reviewed By: cortinico Differential Revision: D49303081
NickGerleman
force-pushed
the
export-D49303081
branch
from
db8379d
to
ec30586
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49303081 |
|
This pull request has been merged in 5ea0b44. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We currently have 854 warnings emitted due to nested namespaces being a C++ 17 extension lol.
This sets the standard explicitly to C++ 20 in the specs emitting the warnings (mostly RCT-Text).
It is undesirable that we add hundreds of warnings to the CocoaPods build without signal. Our Buck build and OSS Android build both treat warnings as errors. But... that is for another day.
Changelog: [Intenrnal]
Differential Revision: D49303081