Remove support for Android API < 23 in PermissionsModule #39680
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48545517 |
|
This pull request was exported from Phabricator. Differential Revision: D48545517 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 26, 2023
) Summary: Pull Request resolved: facebook#39680 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class PermissionsModule chnagelog: [Android][Breaking] Remove support for Android API < 23 in PermissionsModule Reviewed By: NickGerleman Differential Revision: D48545517 fbshipit-source-id: 6bf75f364b2e2d4b46d4d3d469a7c11f70eb8789
mdvacca
force-pushed
the
export-D48545517
branch
from
315709d
to
0c733d2
Compare
Base commit: 5203354 |
|
This pull request was exported from Phabricator. Differential Revision: D48545517 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 26, 2023
) Summary: Pull Request resolved: facebook#39680 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class PermissionsModule chnagelog: [Android][Breaking] Remove support for Android API < 23 in PermissionsModule Reviewed By: NickGerleman Differential Revision: D48545517 fbshipit-source-id: 75820dbb366bfb7fb9aaefc9adb8ba53d845f7bb
mdvacca
force-pushed
the
export-D48545517
branch
from
0c733d2
to
742ea5a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48545517 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 26, 2023
) Summary: Pull Request resolved: facebook#39680 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class PermissionsModule chnagelog: [Android][Breaking] Remove support for Android API < 23 in PermissionsModule Reviewed By: NickGerleman Differential Revision: D48545517 fbshipit-source-id: 6bebb3959312ab8a54b70d693fcecd757224fd1d
mdvacca
force-pushed
the
export-D48545517
branch
from
742ea5a
to
cff404f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48545517 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 26, 2023
) Summary: Pull Request resolved: facebook#39680 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class PermissionsModule chnagelog: [Android][Breaking] Remove support for Android API < 23 in PermissionsModule Reviewed By: NickGerleman Differential Revision: D48545517 fbshipit-source-id: 8f1069b3d24c2c0a0b2b9b15ef86f63d43019f71
mdvacca
force-pushed
the
export-D48545517
branch
from
cff404f
to
b0599e8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48545517 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 27, 2023
) Summary: Pull Request resolved: facebook#39680 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class PermissionsModule chnagelog: [Android][Breaking] Remove support for Android API < 23 in PermissionsModule Reviewed By: NickGerleman Differential Revision: D48545517 fbshipit-source-id: b8880ab16f3cf98cbd056ed1163c471b878515a9
mdvacca
force-pushed
the
export-D48545517
branch
from
b0599e8
to
b909ce3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48545517 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 27, 2023
) Summary: Pull Request resolved: facebook#39680 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class PermissionsModule chnagelog: [Android][Breaking] Remove support for Android API < 23 in PermissionsModule Reviewed By: NickGerleman Differential Revision: D48545517 fbshipit-source-id: cb0876253b8451a619d8b0bf8ad83ed481a4eceb
mdvacca
force-pushed
the
export-D48545517
branch
from
b909ce3
to
fbed97e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48545517 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 27, 2023
) Summary: Pull Request resolved: facebook#39680 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class PermissionsModule changelog: [Android][Breaking] Remove support for Android API < 23 in PermissionsModule Reviewed By: NickGerleman Differential Revision: D48545517 fbshipit-source-id: 0a91ee6205f4e8435d2ce60e0a6eda12b6f052d0
mdvacca
force-pushed
the
export-D48545517
branch
from
fbed97e
to
a55fbfb
Compare
Summary: In this diff I'm increasing the minSdk of RN Android to 23 to keep it in sync with Meta min sdk changelog: [Android][Breaking] Increase min sdk version of RN Android to 23 Differential Revision: D48177965 fbshipit-source-id: 917dd4e98d9a85f858da037a9339a1ab9f84e7e5
Summary: Since minSDK was bumped to Android API 23 we are removing support of code using Android API <23 in chnagelog: [Android][Breaking] Remove support for Android API < 23 in Differential Revision: D48545501 fbshipit-source-id: e969aa45b7f9f7f873f012c06e6ae7cf97d4b149
Summary: Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactFragment chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactFragment Differential Revision: D48545506 fbshipit-source-id: ae66d6b4e251d40a4ce42ac065438888c03a4cf0
Summary: Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class DebugOverlayController chnagelog: [Android][Breaking] Remove support for Android API < 23 in DebugOverlayController Differential Revision: D48545520 fbshipit-source-id: a8867cd036c16515c83d36656df85a721ff7e689
Summary: Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class WindowOverlayCompat chnagelog: [Android][Breaking] Remove support for Android API < 23 in WindowOverlayCompat Differential Revision: D48545505 fbshipit-source-id: 4ee804a6bbbdb531d335c5e580de1bc3e1d1c357
Summary: Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class RequestBodyUtil chnagelog: [Android][Breaking] Remove support for Android API < 23 in RequestBodyUtil Differential Revision: D48545515 fbshipit-source-id: a7532915d09051c1dcbbd73da79a2b3eea77fa4d
|
This pull request was exported from Phabricator. Differential Revision: D48545517 |
) Summary: Pull Request resolved: facebook#39680 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class PermissionsModule changelog: [Android][Breaking] Remove support for Android API < 23 in PermissionsModule Reviewed By: NickGerleman Differential Revision: D48545517 fbshipit-source-id: 344e642964556a1439d6eeacaea8bc99e17d5416
mdvacca
force-pushed
the
export-D48545517
branch
from
a55fbfb
to
0cbde30
Compare
|
This pull request has been merged in 0384e3c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class PermissionsModule
chnagelog: [Android][Breaking] Remove support for Android API < 23 in PermissionsModule
Reviewed By: NickGerleman
Differential Revision: D48545517