Fix android platform border color #39893

axinvd · 2023-10-06T09:03:29Z

Summary:

If you try to apply PlatformColor to borders on Android app will crash with the next error:

"Error while updating property 'borderColor' of a view managed by: RCTView"

Changelog:

[ANDROID] [FIXED] - Fix android crash when apply PlatformColor to borders

Test Plan:

In RNTester example, go to APIs -> PlatformColor

Before	After

facebook-github-bot · 2023-10-06T09:03:35Z

Hi @axinvd!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

analysis-bot · 2023-10-06T09:34:50Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	17,317,608	+7
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	20,685,718	+4
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: 6355703
Branch: main

axinvd · 2023-10-06T09:48:19Z

Fixes:
#38950
#38614
#32942

javache · 2023-10-06T10:11:24Z

Thanks! Could you test this on the new architecture too?

axinvd · 2023-10-06T10:22:28Z

I tested on rn-tester, where new arch enabled by default

javache · 2023-10-06T10:28:56Z

The code you're changing only applies on the old architecture. The new architecture uses BaseViewManagerDelegate, which seems like it still has the same issue.

github-actions · 2023-10-06T10:34:31Z

	Warnings
⚠️	One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against 97743ce

axinvd · 2023-10-06T13:05:16Z

In BaseViewManagerDelegate setting native view properties like setBackgroundColor
BorderColor setting in ReactViewBackgroundDrawable

facebook-github-bot · 2023-10-06T13:26:32Z

@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2023-10-11T15:52:50Z

@javache merged this pull request in 265af22.

Summary: If you try to apply PlatformColor to borders on Android app will crash with the next error: "Error while updating property 'borderColor' of a view managed by: RCTView" ## Changelog: [ANDROID] [FIXED] - Fix android crash when apply PlatformColor to borders Pull Request resolved: facebook#39893 Test Plan: In RNTester example, go to APIs -> PlatformColor | Before | After | | ----------- | ----------- | | <img src="https://github.com/facebook/react-native/assets/70860930/66ac2880-53da-4438-bd9a-332f8ea40645" alt="drawing" width="200"/> | <img src="https://github.com/facebook/react-native/assets/70860930/151f58a1-d857-4b3d-9ec6-de74eb065127" alt="drawing" width="200"/> | Reviewed By: NickGerleman Differential Revision: D50011758 Pulled By: javache fbshipit-source-id: ea06c18c6aef4b6731e9b9b87422a1e0d13de208 (cherry picked from commit 265af22)

Summary: If you try to apply PlatformColor to borders on Android app will crash with the next error: "Error while updating property 'borderColor' of a view managed by: RCTView" ## Changelog: [ANDROID] [FIXED] - Fix android crash when apply PlatformColor to borders Pull Request resolved: #39893 Test Plan: In RNTester example, go to APIs -> PlatformColor | Before | After | | ----------- | ----------- | | <img src="https://github.com/facebook/react-native/assets/70860930/66ac2880-53da-4438-bd9a-332f8ea40645" alt="drawing" width="200"/> | <img src="https://github.com/facebook/react-native/assets/70860930/151f58a1-d857-4b3d-9ec6-de74eb065127" alt="drawing" width="200"/> | Reviewed By: NickGerleman Differential Revision: D50011758 Pulled By: javache fbshipit-source-id: ea06c18c6aef4b6731e9b9b87422a1e0d13de208

Summary: If you try to apply PlatformColor to borders on Android app will crash with the next error: "Error while updating property 'borderColor' of a view managed by: RCTView" ## Changelog: [ANDROID] [FIXED] - Fix android crash when apply PlatformColor to borders Pull Request resolved: facebook#39893 Test Plan: In RNTester example, go to APIs -> PlatformColor | Before | After | | ----------- | ----------- | | <img src="https://github.com/facebook/react-native/assets/70860930/66ac2880-53da-4438-bd9a-332f8ea40645" alt="drawing" width="200"/> | <img src="https://github.com/facebook/react-native/assets/70860930/151f58a1-d857-4b3d-9ec6-de74eb065127" alt="drawing" width="200"/> | Reviewed By: NickGerleman Differential Revision: D50011758 Pulled By: javache fbshipit-source-id: ea06c18c6aef4b6731e9b9b87422a1e0d13de208

Summary: If you try to apply PlatformColor to borders on Android app will crash with the next error: "Error while updating property 'borderColor' of a view managed by: RCTView" ## Changelog: [ANDROID] [FIXED] - Fix android crash when apply PlatformColor to borders Pull Request resolved: #39893 Test Plan: In RNTester example, go to APIs -> PlatformColor | Before | After | | ----------- | ----------- | | <img src="https://github.com/facebook/react-native/assets/70860930/66ac2880-53da-4438-bd9a-332f8ea40645" alt="drawing" width="200"/> | <img src="https://github.com/facebook/react-native/assets/70860930/151f58a1-d857-4b3d-9ec6-de74eb065127" alt="drawing" width="200"/> | Reviewed By: NickGerleman Differential Revision: D50011758 Pulled By: javache fbshipit-source-id: ea06c18c6aef4b6731e9b9b87422a1e0d13de208

* Fix android platform border color (#39893) Summary: If you try to apply PlatformColor to borders on Android app will crash with the next error: "Error while updating property 'borderColor' of a view managed by: RCTView" ## Changelog: [ANDROID] [FIXED] - Fix android crash when apply PlatformColor to borders Pull Request resolved: #39893 Test Plan: In RNTester example, go to APIs -> PlatformColor | Before | After | | ----------- | ----------- | | <img src="https://github.com/facebook/react-native/assets/70860930/66ac2880-53da-4438-bd9a-332f8ea40645" alt="drawing" width="200"/> | <img src="https://github.com/facebook/react-native/assets/70860930/151f58a1-d857-4b3d-9ec6-de74eb065127" alt="drawing" width="200"/> | Reviewed By: NickGerleman Differential Revision: D50011758 Pulled By: javache fbshipit-source-id: ea06c18c6aef4b6731e9b9b87422a1e0d13de208 * Android: fix ClassCastException in ReactRootView.java when software keyboard is shown (#40755) Summary: Fixes #40754 Hi all! We noticed that our app started to crash after bumping to RN v0.71.13, anyways after a deeper investigation we also found that the crash occurs in the latest version as well. Crash log: ``` E FATAL EXCEPTION: main Process: com.nfl.fantasy.core.android.debug, PID: 6034 java.lang.ClassCastException: android.app.ContextImpl cannot be cast to android.app.Activity at com.facebook.react.ReactRootView$CustomGlobalLayoutListener.getActivity(ReactRootView.java:926) at com.facebook.react.ReactRootView$CustomGlobalLayoutListener.checkForKeyboardEvents(ReactRootView.java:946) at com.facebook.react.ReactRootView$CustomGlobalLayoutListener.onGlobalLayout(ReactRootView.java:912) at android.view.ViewTreeObserver.dispatchOnGlobalLayout(ViewTreeObserver.java:1061) ``` The code which causes ClassCastException is following [here](https://github.com/facebook/react-native/blob/ea88fbe229e1d276753ee8e118184274fc872138/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactRootView.java#L864). In this code explicit type conversion to Activity is not safe because it's not guaranteed by the compiler that context will be compatible with Activity type. The appropriate issue [has been filed](#40754).  [ANDROID] [FIXED] - Fixed crash occurring in certain native views when keyboard events are fired. Pull Request resolved: #40755 Test Plan: Tested it manually with the [reference application](https://github.com/kot331107/rnCrashReproducer). Repro steps are as follows: - Build and run the app on Android - Tap the button "Open Modal" - You should see the red popup fragment to the bottom of the screen - Tap on the text input to open software keyboard - Expected: it should show the keyboard and no crash happens. Reviewed By: arushikesarwani94 Differential Revision: D50198424 Pulled By: NickGerleman fbshipit-source-id: a5a6d86334856f4ffbe818150da5793380da4702 * chore: bump podfile.lock --------- Co-authored-by: Ivan Alexandrov <axinvd@gmail.com> Co-authored-by: Filipp Mikheev <kot331107@gmail.com>

Fix android platform border color

fbf14cb

Revert types changing

c8db188

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Oct 6, 2023

Revert color casting

97743ce

facebook-github-bot closed this in 265af22 Oct 11, 2023

facebook-github-bot added the Merged This PR has been merged. label Oct 11, 2023

This was referenced Oct 17, 2023

Fix android platform border color (#39893) #41029

Closed

Fix android platform border color (#39893) #41030

Closed

NOUIY mentioned this pull request Dec 8, 2023

[Snyk] Upgrade react-native from 0.63.3 to 0.72.7 NOUIY/react-native-macos#1208

Open

cipolleschi mentioned this pull request Dec 27, 2023

[RN][iOS] Improve Swift support for 3rd party libs #42075

Merged

This was referenced Jan 4, 2024

[RN][iOS] Disable Bitcode for Hermes #42142

Merged

[Local][RN][General] 0.72 - migrate boost away from JFrog #42175

Merged

cipolleschi mentioned this pull request Jan 19, 2024

[RN][iOS] Fix race condition between A11yManager and UIManager #42382

Merged

NOUIY mentioned this pull request Jan 29, 2024

[Snyk] Upgrade react-native from 0.63.3 to 0.73.2 NOUIY/react-native-macos#1238

Open

cipolleschi mentioned this pull request Jan 30, 2024

[RN][iOS] Fix warning when loading RCTUIManager and A11yManager #42734

Merged

cipolleschi mentioned this pull request Feb 19, 2024

[RN][iOS] Fix compiler flags passed to libraries #43088

Merged

cipolleschi mentioned this pull request Apr 5, 2024

[Yoga][0.73] Fix archive for MacOS Catalyst #43896

Merged

This was referenced Jun 28, 2024

[CI] Move machines to M1 for 0.73 #45214

Merged

[CI] Move machines to M1 for 0.72 #45215

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix android platform border color #39893

Fix android platform border color #39893

axinvd commented Oct 6, 2023

facebook-github-bot commented Oct 6, 2023

analysis-bot commented Oct 6, 2023 •

edited

Loading

axinvd commented Oct 6, 2023

javache commented Oct 6, 2023

axinvd commented Oct 6, 2023

javache commented Oct 6, 2023

github-actions bot commented Oct 6, 2023 •

edited

Loading

axinvd commented Oct 6, 2023

facebook-github-bot commented Oct 6, 2023

facebook-github-bot commented Oct 11, 2023

Fix android platform border color #39893

Fix android platform border color #39893

Conversation

axinvd commented Oct 6, 2023

Summary:

Changelog:

Test Plan:

facebook-github-bot commented Oct 6, 2023

Action Required

Process

analysis-bot commented Oct 6, 2023 • edited Loading

axinvd commented Oct 6, 2023

javache commented Oct 6, 2023

axinvd commented Oct 6, 2023

javache commented Oct 6, 2023

github-actions bot commented Oct 6, 2023 • edited Loading

axinvd commented Oct 6, 2023

facebook-github-bot commented Oct 6, 2023

facebook-github-bot commented Oct 11, 2023

analysis-bot commented Oct 6, 2023 •

edited

Loading

github-actions bot commented Oct 6, 2023 •

edited

Loading