Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark LazyReactPackage as Deprecated in the new architecture of React Native #41097

Closed
wants to merge 1 commit into from

Conversation

mdvacca
Copy link
Contributor

@mdvacca mdvacca commented Oct 19, 2023

Summary:
LazyReactPackage is beig replaced by TurboReactPackage / BaseReactPackage, that's why I'm docummenting LazyReactPackage as Deprecated

changelog: [internal] internal

Reviewed By: arushikesarwani94

Differential Revision: D50338301

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Oct 19, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50338301

@analysis-bot
Copy link

analysis-bot commented Oct 19, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,653,236 -18
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,035,016 +5
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: daedbe6
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50338301

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50338301

mdvacca added a commit to mdvacca/react-native that referenced this pull request Oct 21, 2023
…Native (facebook#41097)

Summary:

LazyReactPackage is beig replaced by TurboReactPackage / BaseReactPackage, that's why I'm docummenting LazyReactPackage as Deprecated

changelog: [internal] internal

Reviewed By: arushikesarwani94

Differential Revision: D50338301
mdvacca added a commit to mdvacca/react-native that referenced this pull request Oct 21, 2023
…Native (facebook#41097)

Summary:

LazyReactPackage is beig replaced by TurboReactPackage / BaseReactPackage, that's why I'm docummenting LazyReactPackage as Deprecated

changelog: [internal] internal

Reviewed By: arushikesarwani94

Differential Revision: D50338301
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50338301

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50338301

@mdvacca mdvacca force-pushed the export-D50338301 branch 2 times, most recently from 6073855 to e33427a Compare October 23, 2023 16:20
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50338301

mdvacca added a commit to mdvacca/react-native that referenced this pull request Oct 23, 2023
…Native (facebook#41097)

Summary:

LazyReactPackage is beig replaced by TurboReactPackage / BaseReactPackage, that's why I'm docummenting LazyReactPackage as Deprecated

changelog: [internal] internal

Reviewed By: arushikesarwani94

Differential Revision: D50338301
mdvacca added a commit to mdvacca/react-native that referenced this pull request Oct 23, 2023
…Native (facebook#41097)

Summary:

LazyReactPackage is beig replaced by TurboReactPackage / BaseReactPackage, that's why I'm docummenting LazyReactPackage as Deprecated

changelog: [internal] internal

Reviewed By: arushikesarwani94

Differential Revision: D50338301
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50338301

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50338301

@mdvacca mdvacca force-pushed the export-D50338301 branch 2 times, most recently from 6e04bfd to 465fc3e Compare October 24, 2023 20:42
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50338301

mdvacca added a commit to mdvacca/react-native that referenced this pull request Oct 24, 2023
…Native (facebook#41097)

Summary:

LazyReactPackage is beig replaced by TurboReactPackage / BaseReactPackage, that's why I'm docummenting LazyReactPackage as Deprecated

changelog: [internal] internal

Reviewed By: arushikesarwani94

Differential Revision: D50338301
mdvacca added a commit to mdvacca/react-native that referenced this pull request Oct 25, 2023
…Native (facebook#41097)

Summary:

LazyReactPackage is beig replaced by TurboReactPackage / BaseReactPackage, that's why I'm docummenting LazyReactPackage as Deprecated

changelog: [internal] internal

Reviewed By: arushikesarwani94

Differential Revision: D50338301
mdvacca added a commit to mdvacca/react-native that referenced this pull request Oct 25, 2023
…Native (facebook#41097)

Summary:

LazyReactPackage is beig replaced by TurboReactPackage / BaseReactPackage, that's why I'm docummenting LazyReactPackage as Deprecated

changelog: [internal] internal

Reviewed By: arushikesarwani94

Differential Revision: D50338301
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50338301

mdvacca added a commit to mdvacca/react-native that referenced this pull request Oct 26, 2023
…Native (facebook#41097)

Summary:

LazyReactPackage is beig replaced by TurboReactPackage / BaseReactPackage, that's why I'm docummenting LazyReactPackage as Deprecated

changelog: [internal] internal

Reviewed By: arushikesarwani94

Differential Revision: D50338301
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50338301

…Native (facebook#41097)

Summary:

LazyReactPackage is beig replaced by TurboReactPackage / BaseReactPackage, that's why I'm docummenting LazyReactPackage as Deprecated

changelog: [internal] internal

Reviewed By: arushikesarwani94

Differential Revision: D50338301
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50338301

mdvacca added a commit to mdvacca/react-native that referenced this pull request Oct 27, 2023
…Native (facebook#41097)

Summary:

LazyReactPackage is beig replaced by TurboReactPackage / BaseReactPackage, that's why I'm docummenting LazyReactPackage as Deprecated

changelog: [internal] internal

Reviewed By: arushikesarwani94

Differential Revision: D50338301
@github-actions
Copy link

This pull request was successfully merged by @mdvacca in bfc64f4.

When will my fix make it into a release? | Upcoming Releases

@github-actions github-actions bot added the Merged This PR has been merged. label Oct 27, 2023
Othinn pushed a commit to Othinn/react-native that referenced this pull request Oct 30, 2023
…Native (facebook#41097)

Summary:
Pull Request resolved: facebook#41097

LazyReactPackage is beig replaced by TurboReactPackage / BaseReactPackage, that's why I'm docummenting LazyReactPackage as Deprecated

changelog: [internal] internal

Reviewed By: arushikesarwani94

Differential Revision: D50338301

fbshipit-source-id: 6093772400ccaf928a549c078791845513dcb56a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants