Handle source file / source map fetch errors correctly, add tests #41342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51013054 |
|
This pull request was exported from Phabricator. Differential Revision: D51013054 |
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Nov 6, 2023
…cebook#41342) Summary: Pull Request resolved: facebook#41342 While rewriting `Debugger.getScriptSource` messages to fetch code and source map over HTTP, we weren't checking the status code of the fetch calls. This diff fixes that and adds corresponding tests (as well as for the filesystem error case). Changelog: [Internal] Differential Revision: D51013054 fbshipit-source-id: 4b593c0b13d1fb8db9b8a6ed1b123d93349ff5b5
motiz88
force-pushed
the
export-D51013054
branch
from
b867a21 to
9a7d85d
Compare
Base commit: 47f773e |
|
This pull request was exported from Phabricator. Differential Revision: D51013054 |
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Nov 8, 2023
…cebook#41342) Summary: Pull Request resolved: facebook#41342 While rewriting `Debugger.getScriptSource` messages to fetch code and source map over HTTP, we weren't checking the status code of the fetch calls. This diff fixes that and adds corresponding tests (as well as for the filesystem error case). Changelog: [Internal] Differential Revision: D51013054 fbshipit-source-id: 7b3bfb0ae5d48b2a167ba5852cb093a3035dac73
motiz88
force-pushed
the
export-D51013054
branch
from
9a7d85d to
8c209fc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51013054 |
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Nov 8, 2023
…cebook#41342) Summary: Pull Request resolved: facebook#41342 While rewriting `Debugger.getScriptSource` messages to fetch code and source map over HTTP, we weren't checking the status code of the fetch calls. This diff fixes that and adds corresponding tests (as well as for the filesystem error case). Changelog: [Internal] Differential Revision: D51013054 fbshipit-source-id: 30a3ec64f35409c715049d82e0eff25560ac3be9
motiz88
force-pushed
the
export-D51013054
branch
from
8c209fc to
f85b0b3
Compare
Differential Revision: D50980467 fbshipit-source-id: 24c9619559cc7fe0173fd59e7b008109aed5e2b4
Differential Revision: D51002263 fbshipit-source-id: aaefde6ab2539eb63966457520b0e668302dfd57
Differential Revision: D51002261 fbshipit-source-id: b4ac12a9567560d07e87f0a0dde2d865cc9a6e68
Differential Revision: D51002262 fbshipit-source-id: e9c05b00e6d30285fa99b33bab4fb15103998456
Differential Revision: D51006835 fbshipit-source-id: 0118c93bb229ab158aecf3ef0c7d3f19f4396e8d
Differential Revision: D51013055 fbshipit-source-id: bde65eb216329b334d058757da2e6a82018f5505
Differential Revision: D51013052 fbshipit-source-id: 6138dffcd66557d26cdeef435986b57c801f442e
Differential Revision: D51013053 fbshipit-source-id: 96e4dc32338831ebfbefd72ae372164df3356623
…cebook#41342) Summary: Pull Request resolved: facebook#41342 While rewriting `Debugger.getScriptSource` messages to fetch code and source map over HTTP, we weren't checking the status code of the fetch calls. This diff fixes that and adds corresponding tests (as well as for the filesystem error case). Changelog: [Internal] Reviewed By: robhogan Differential Revision: D51013054 fbshipit-source-id: 33959b3de7a17e64de864bc03801e61f27cfc18b
|
This pull request was exported from Phabricator. Differential Revision: D51013054 |
motiz88
force-pushed
the
export-D51013054
branch
from
f85b0b3 to
099679d
Compare
|
This pull request has been merged in 1bcd286. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
…cebook#41342) Summary: Pull Request resolved: facebook#41342 While rewriting `Debugger.getScriptSource` messages to fetch code and source map over HTTP, we weren't checking the status code of the fetch calls. This diff fixes that and adds corresponding tests (as well as for the filesystem error case). Changelog: [Internal] Reviewed By: robhogan Differential Revision: D51013054 fbshipit-source-id: 58e7bb9fcd6a3cf92329b43fb8a139093c80d305
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
While rewriting
Debugger.getScriptSourcemessages to fetch code and source map over HTTP, we weren't checking the status code of the fetch calls. This diff fixes that and adds corresponding tests (as well as for the filesystem error case).Changelog: [Internal]
Differential Revision: D51013054