fix use out-of-scope memory warning #41441
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51233760 |
sammy-SC
force-pushed
the
export-D51233760
branch
from
d8b8353 to
1eb9970
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51233760 |
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Nov 13, 2023
Summary: changelog: [internal] Reviewed By: cipolleschi Differential Revision: D51233760
sammy-SC
force-pushed
the
export-D51233760
branch
from
1eb9970 to
358291f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51233760 |
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Nov 13, 2023
Summary: changelog: [internal] Reviewed By: cipolleschi Differential Revision: D51233760
sammy-SC
force-pushed
the
export-D51233760
branch
from
358291f to
7e24652
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51233760 |
Base commit: caed1dc |
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Nov 13, 2023
Summary: changelog: [internal] Reviewed By: cipolleschi Differential Revision: D51233760
sammy-SC
force-pushed
the
export-D51233760
branch
from
7e24652 to
3836f28
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51233760 |
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Nov 13, 2023
Summary: changelog: [internal] Reviewed By: cipolleschi Differential Revision: D51233760
sammy-SC
force-pushed
the
export-D51233760
branch
from
3836f28 to
1a1b40f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51233760 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D51233760 |
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Nov 13, 2023
Summary: changelog: [internal] Reviewed By: cipolleschi Differential Revision: D51233760
sammy-SC
force-pushed
the
export-D51233760
branch
from
1a1b40f to
f3b3b0f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51233760 |
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Nov 13, 2023
Summary: changelog: [internal] Reviewed By: cipolleschi Differential Revision: D51233760
sammy-SC
force-pushed
the
export-D51233760
branch
from
f3b3b0f to
fb6698e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51233760 |
|
This pull request was exported from Phabricator. Differential Revision: D51233760 |
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Nov 13, 2023
Summary: changelog: [internal] Reviewed By: cipolleschi Differential Revision: D51233760
sammy-SC
force-pushed
the
export-D51233760
branch
from
fb6698e to
e7225b4
Compare
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Nov 13, 2023
Summary: changelog: [internal] Reviewed By: cipolleschi Differential Revision: D51233760
sammy-SC
force-pushed
the
export-D51233760
branch
from
e7225b4 to
0ac70f6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51233760 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D51233760 |
sammy-SC
force-pushed
the
export-D51233760
branch
from
0ac70f6 to
1bdad61
Compare
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Nov 14, 2023
Summary: changelog: [internal] Reviewed By: cipolleschi Differential Revision: D51233760
|
This pull request was exported from Phabricator. Differential Revision: D51233760 |
Summary: changelog: [internal] Reviewed By: cipolleschi Differential Revision: D51233760
sammy-SC
force-pushed
the
export-D51233760
branch
from
1bdad61 to
09c1e2e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51233760 |
|
This pull request was successfully merged by @sammy-SC in f1925c2. When will my fix make it into a release? | Upcoming Releases |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: Pull Request resolved: facebook#41441 changelog: [internal] Reviewed By: cipolleschi Differential Revision: D51233760 fbshipit-source-id: 5fc7ab22220e3d80729243e715e22e85e3ba7afa
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
May 21, 2024
Summary: Pull Request resolved: facebook#41441 changelog: [internal] Reviewed By: cipolleschi Differential Revision: D51233760 fbshipit-source-id: 5fc7ab22220e3d80729243e715e22e85e3ba7afa
Saadnajmi
added a commit
to microsoft/react-native-macos
that referenced
this pull request
May 21, 2024
* Replace `--frozen-lockfile` with --immutable * Remove `apple-install-dependencies * Update apple-xcode-select * Use macos-13-arm64 * Build Debug only * Use custom Xcodebuild template * Separate build & test * Use Codeql v2 * Update template syntax * try major refactor * rename apple-job-publish * try big 2 * Fix Hermes * Comment out test temporarily * Fix visionOS + New Arch + JSC * Move iOS down, visionOS -> xrOS * Comment out failing jobs * Update build-test-rntester.yml * Move scripts to scripts folder * Update RNTA script for RNM use * Update VM image per notice * Update gitignore * Don't test on visionOS * fix use out-of-scope memory warning (facebook#41441) Summary: Pull Request resolved: facebook#41441 changelog: [internal] Reviewed By: cipolleschi Differential Revision: D51233760 fbshipit-source-id: 5fc7ab22220e3d80729243e715e22e85e3ba7afa * Retry xcode tests on failure --------- Co-authored-by: Samuel Susla <samuelsusla@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: changelog: [internal]
Reviewed By: cipolleschi
Differential Revision: D51233760