Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix React-Codegen dependencies on FabricImage #41640

Closed
wants to merge 1 commit into from
Closed

Fix React-Codegen dependencies on FabricImage #41640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...ct-native/ReactCommon/react/renderer/imagemanager/platform/ios/React-ImageManager.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ Pod::Spec.new do |s|

s.dependency "RCT-Folly/Fabric"
s.dependency "React-Core/Default"
s.dependency "React-RCTImage"
s.dependency "glog"

add_dependency(s, "React-Fabric")
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/scripts/cocoapods/__tests__/codegen_utils-test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,6 +559,7 @@ def get_podspec_fabric_and_script_phases(script_phases)
specs[:dependencies].merge!({
'React-graphics': [],
'React-Fabric': [],
'React-FabricImage': [],
'React-utils': [],
'React-debug': [],
'React-rendererdebug': [],
Expand All @@ -578,6 +579,7 @@ def get_podspec_when_use_frameworks
specs[:dependencies].merge!({
'React-graphics': [],
'React-Fabric': [],
'React-FabricImage': [],
'React-utils': [],
'React-debug': [],
'React-rendererdebug': [],
Expand Down
1 change: 1 addition & 0 deletions packages/react-native/scripts/cocoapods/codegen_utils.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ def get_react_codegen_spec(package_json_file, folly_version: '2023.08.07.00', he
'React-graphics': [],
'React-rendererdebug': [],
'React-Fabric': [],
'React-FabricImage': [],
'React-debug': [],
'React-utils': [],
}
Expand Down