Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply stack Symbolication patch part 1 & 2 to 0.71-stable (#41377) (#42079) (original #40914) #42222

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

joe-sam
Copy link

@joe-sam joe-sam commented Jan 10, 2024

Summary:

Apply stack Symbolication patch part 1 & 2 to 0.71-stable (#41377) (#42079) (original #40914)

This "cherry picked" PR is redone and should retain the old flow type compatibility (across 0.71-stable) which is currently different from main.

Changelog:

LogBox shows improvement in stack trace for custom errors.

Test Plan:

Same as previous test plans (#41377) (#42079) (original #40914)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 10, 2024
@joe-sam
Copy link
Author

joe-sam commented Jan 10, 2024

I redid the earlier cherry-pick commits which had merge conflicts probably due to incompatible flow types/typescript types currently on main and squashed all the changes into a commit and rebased branch to 0.71-stable.

@hurali97 hurali97 merged commit 568031e into facebook:0.71-stable Jan 15, 2024
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants