Fix RCTFabric podspec #42639
Closed
Fix RCTFabric podspec #42639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D53048270 |
Summary: When I reverted part of the deprecation of `RCT_NEW_ARCH_ENABLED`, I forget a little bit which was breaking RCTFabric podspec. This diff fixes that. ## Changelog: [Internal] - Bring back `RCT_NEW_ARCH_ENABLED` to Fabric to make the `RCTThirdPartyFabricComponentsProvider` work again. Reviewed By: cortinico Differential Revision: D53048270
cipolleschi
force-pushed
the
export-D53048270
branch
from
e4825d4
to
73921c8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53048270 |
|
This pull request has been merged in f4dbd15. |
|
Did this get released? |
|
Not yet, it will be included in 0.74. |
lunaleaps
pushed a commit
that referenced
this pull request
Feb 20, 2024
Summary: Pull Request resolved: #42639 When I reverted part of the deprecation of `RCT_NEW_ARCH_ENABLED`, I forget a little bit which was breaking RCTFabric podspec. This diff fixes that. [Internal] - Bring back `RCT_NEW_ARCH_ENABLED` to Fabric to make the `RCTThirdPartyFabricComponentsProvider` work again. Reviewed By: cortinico Differential Revision: D53048270 fbshipit-source-id: d21e833c10b332fb70147cc65b690f88016655e6
This was referenced Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When I reverted part of the deprecation of
RCT_NEW_ARCH_ENABLED, I forget a little bit which was breaking RCTFabric podspec.This diff fixes that.
Changelog:
[Internal] - Bring back
RCT_NEW_ARCH_ENABLEDto Fabric to make theRCTThirdPartyFabricComponentsProviderwork again.Differential Revision: D53048270