Standalone Gradle plugin: Node.js package resolver #42823
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52998256 |
|
This pull request was exported from Phabricator. Differential Revision: D52998256 |
robhogan
added a commit
to robhogan/react-native
that referenced
this pull request
Feb 2, 2024
Summary: Pull Request resolved: facebook#42823 This is a tiny new Gradle plugin intended to be published to the Gradle Plugin Portal independently of React Native. It's only function is to resolve `node_modules` package roots using a sufficient subset of the Node JS resolution algorithm - e.g, we can use it to find `react-native` itself from a user's project, whatever package manager or workspace setup they're using, in a Gradle-friendly, cacheable manner. The plugin is both a `Settings` plugin and a `Project` plugin, so that it may be used from both `settings.gradle` (where we need it to resolve `react-native`) and `app/build.gradle` (which currently applies from `cli-platform-android`). The setup is mostly `gradle init` with a few modifications (eg, Kotlin JVM version) to stay close to the setup for `react-native-gradle-plugin`. I think it's easier to reason about this currently as an entirely separate Gradle project, but we may be able to merge the two and reduce some duplication once it's proven. Changelog: [General][Added] - Gradle plugin for resolving node_modules packages. Reviewed By: cortinico Differential Revision: D52998256 fbshipit-source-id: 9e36f4796a2d57015a5fe5dd9616acf2a31a4e03
robhogan
force-pushed
the
export-D52998256
branch
from
416d5e9
to
70609a2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52998256 |
robhogan
added a commit
to robhogan/react-native
that referenced
this pull request
Feb 2, 2024
Summary: Pull Request resolved: facebook#42823 This is a tiny new Gradle plugin intended to be published to the Gradle Plugin Portal independently of React Native. It's only function is to resolve `node_modules` package roots using a sufficient subset of the Node JS resolution algorithm - e.g, we can use it to find `react-native` itself from a user's project, whatever package manager or workspace setup they're using, in a Gradle-friendly, cacheable manner. The plugin is both a `Settings` plugin and a `Project` plugin, so that it may be used from both `settings.gradle` (where we need it to resolve `react-native`) and `app/build.gradle` (which currently applies from `cli-platform-android`). The setup is mostly `gradle init` with a few modifications (eg, Kotlin JVM version) to stay close to the setup for `react-native-gradle-plugin`. I think it's easier to reason about this currently as an entirely separate Gradle project, but we may be able to merge the two and reduce some duplication once it's proven. Changelog: [General][Added] - Gradle plugin for resolving node_modules packages. Reviewed By: cortinico Differential Revision: D52998256 fbshipit-source-id: e748148ab8c2c67f12f3649304d3263cde8267e2
robhogan
force-pushed
the
export-D52998256
branch
from
70609a2
to
59fc369
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52998256 |
robhogan
force-pushed
the
export-D52998256
branch
from
59fc369
to
a902d73
Compare
robhogan
added a commit
to robhogan/react-native
that referenced
this pull request
Feb 5, 2024
Summary: Pull Request resolved: facebook#42823 This is a tiny new Gradle plugin intended to be published to the Gradle Plugin Portal independently of React Native. It's only function is to resolve `node_modules` package roots using a sufficient subset of the Node JS resolution algorithm - e.g, we can use it to find `react-native` itself from a user's project, whatever package manager or workspace setup they're using, in a Gradle-friendly, cacheable manner. The plugin is both a `Settings` plugin and a `Project` plugin, so that it may be used from both `settings.gradle` (where we need it to resolve `react-native`) and `app/build.gradle` (which currently applies from `cli-platform-android`). The setup is mostly `gradle init` with a few modifications (eg, Kotlin JVM version) to stay close to the setup for `react-native-gradle-plugin`. I think it's easier to reason about this currently as an entirely separate Gradle project, but we may be able to merge the two and reduce some duplication once it's proven. Changelog: [General][Added] - Gradle plugin for resolving node_modules packages. Reviewed By: cortinico Differential Revision: D52998256 fbshipit-source-id: 2e09d34a176e66d2e8ad3cc91803cd8669e4d9e4
Summary: Pull Request resolved: facebook#42823 This is a tiny new Gradle plugin intended to be published to the Gradle Plugin Portal independently of React Native. It's only function is to resolve `node_modules` package roots using a sufficient subset of the Node JS resolution algorithm - e.g, we can use it to find `react-native` itself from a user's project, whatever package manager or workspace setup they're using, in a Gradle-friendly, cacheable manner. The plugin is both a `Settings` plugin and a `Project` plugin, so that it may be used from both `settings.gradle` (where we need it to resolve `react-native`) and `app/build.gradle` (which currently applies from `cli-platform-android`). The setup is mostly `gradle init` with a few modifications (eg, Kotlin JVM version) to stay close to the setup for `react-native-gradle-plugin`. I think it's easier to reason about this currently as an entirely separate Gradle project, but we may be able to merge the two and reduce some duplication once it's proven. Changelog: [General][Added] - Gradle plugin for resolving node_modules packages. Reviewed By: cortinico Differential Revision: D52998256 fbshipit-source-id: 16b9096b21aaaf1ad7bc462423253a126f29b14c
|
This pull request was exported from Phabricator. Differential Revision: D52998256 |
robhogan
force-pushed
the
export-D52998256
branch
from
a902d73
to
1242530
Compare
|
This pull request has been merged in 8456cca. |
|
This pull request has been reverted by 48a19d7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is a tiny new Gradle plugin intended to be published to the Gradle Plugin Portal independently of React Native. It's only function is to resolve
node_modulespackage roots using a sufficient subset of the Node JS resolution algorithm - e.g, we can use it to findreact-nativeitself from a user's project, whatever package manager or workspace setup they're using, in a Gradle-friendly, cacheable manner.The plugin is both a
Settingsplugin and aProjectplugin, so that it may be used from bothsettings.gradle(where we need it to resolvereact-native) andapp/build.gradle(which currently applies fromcli-platform-android).The setup is mostly
gradle initwith a few modifications (eg, Kotlin JVM version) to stay close to the setup forreact-native-gradle-plugin. I think it's easier to reason about this currently as an entirely separate Gradle project, but we may be able to merge the two and reduce some duplication once it's proven.Changelog:
[General][Added] - Gradle plugin for resolving node_modules packages.
Reviewed By: cortinico
Differential Revision: D52998256