Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LOCAL][0.73] fix: cannot find module react-native-*/Libraries/Core/InitializeCore #42877

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

tido64
Copy link
Collaborator

@tido64 tido64 commented Feb 5, 2024

Summary:

@react-native/community-cli-plugin is unable to resolve out-of-tree platforms in monorepos because the package may not be hoisted to the same location. For example, if @react-native/community-cli-plugin was hoisted:

/~/node_modules/@react-native/community-cli-plugin/dist/utils

It may never find react-native-macos if it wasn't hoisted:

/~/packages/my-app/node_modules/react-native-macos

Changelog:

[GENERAL] [FIXED] - Fix @react-native/community-cli-plugin is unable to resolve out-of-tree platforms in monorepos

Test Plan:

Cherry-picks #42875

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Microsoft Partner: Microsoft Partner labels Feb 5, 2024
@robhogan robhogan changed the title fix: cannot find module react-native-*/Libraries/Core/InitializeCore [LOCAL][0.73] fix: cannot find module react-native-*/Libraries/Core/InitializeCore Feb 5, 2024
@robhogan
Copy link
Contributor

robhogan commented Feb 5, 2024

Thanks @tido64

CC @lunaleaps + @blakef, I'm not sure whether it's OK to merge this directly or if you'd prefer to pick it - it just landed on main: e350859.

@lunaleaps
Copy link
Contributor

Yea I don't think it makes a difference, I'll just merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Microsoft Partner: Microsoft Partner Pick Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants