Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove source usages from getInspectorData #43020

Closed
wants to merge 1 commit into from
Closed

refactor: remove source usages from getInspectorData #43020

wants to merge 1 commit into from

Conversation

hoxyq
Copy link
Contributor

@hoxyq hoxyq commented Feb 14, 2024

Summary:
Changelog: [Internal]

Required for landing D53543159.

3 reasons for landing this:

  1. Inspector is technically deprecated and will be removed once React DevTools are shipped with Chrome DevTools for RN debugging.
  2. Long-term solution for source fetching is lazy loading based on component stacks - Remove __self and __source location from elements react#28265
  3. Although source field is accumulated and stored, it is not displayed anywhere, see InspectorOverlay.js.

Differential Revision: D53757524

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 14, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53757524

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53757524

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53757524

@hoxyq hoxyq force-pushed the export-D53757524 branch 4 times, most recently from fbbb2a7 to d139db2 Compare February 14, 2024 13:09
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53757524

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53757524

2 similar comments
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53757524

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53757524

@hoxyq @facebook-github-bot
refactor: remove source usages from getInspectorData
25dad31 
Summary:
Changelog: [Internal]

Required for landing D53543159.

2 reasons for landing this:
1. Inspector is technically deprecated and will be removed once React DevTools are shipped with Chrome DevTools for RN debugging.
2. Long-term solution for source fetching is lazy loading based on component stacks - facebook/react#28265

Differential Revision: D53757524
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53757524

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53757524

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53757524

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,750,503 -54
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,108,988 -11
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 48f1f2d
Branch: main

@hoxyq
Copy link
Contributor Author

hoxyq commented Feb 19, 2024

Landed in ca141d9.

@hoxyq hoxyq closed this Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported p: Facebook Partner: Facebook Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hoxyq @facebook-github-bot @analysis-bot