Fix test-e2e-local when building artifacts locally #43043
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D53806191 |
Summary: Restores behaviour of `yarn test-e2e-local` when we are not using `--circleciToken`. The `npm pack` logic (necessary for the subsequent `updateTemplatePackage` call before initing `RNTestProject`) was deleted in facebook#41172 / D50651448. facebook@4eed12b#diff-56f57bf0eac99b0fda1b2938aceb8d9b663db82c07cb405bd53a01c8689710ffL224-L240 Changelog: [Internal] Differential Revision: D53806191
huntie
force-pushed
the
export-D53806191
branch
from
d680580
to
ff01a85
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53806191 |
Base commit: 59d46e8 |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Feb 15, 2024
…k#43043) Summary: Restores behaviour of `yarn test-e2e-local` when we are not using `--circleciToken`. The `npm pack` logic (necessary for the subsequent `updateTemplatePackage` call before initing `RNTestProject`) was deleted in facebook#41172 / D50651448. facebook@4eed12b#diff-56f57bf0eac99b0fda1b2938aceb8d9b663db82c07cb405bd53a01c8689710ffL224-L240 Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D53806191
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Feb 15, 2024
…k#43043) Summary: Restores behaviour of `yarn test-e2e-local` when we are not using `--circleciToken`. The `npm pack` logic (necessary for the subsequent `updateTemplatePackage` call before initing `RNTestProject`) was deleted in facebook#41172 / D50651448. facebook@4eed12b#diff-56f57bf0eac99b0fda1b2938aceb8d9b663db82c07cb405bd53a01c8689710ffL224-L240 Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D53806191
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Feb 15, 2024
…k#43043) Summary: Restores behaviour of `yarn test-e2e-local` when we are not using `--circleciToken`. The `npm pack` logic (necessary for the subsequent `updateTemplatePackage` call before initing `RNTestProject`) was deleted in facebook#41172 / D50651448. facebook@4eed12b#diff-56f57bf0eac99b0fda1b2938aceb8d9b663db82c07cb405bd53a01c8689710ffL224-L240 Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D53806191
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Feb 15, 2024
…k#43043) Summary: Restores behaviour of `yarn test-e2e-local` when we are not using `--circleciToken`. The `npm pack` logic (necessary for the subsequent `updateTemplatePackage` call before initing `RNTestProject`) was deleted in facebook#41172 / D50651448. facebook@4eed12b#diff-56f57bf0eac99b0fda1b2938aceb8d9b663db82c07cb405bd53a01c8689710ffL224-L240 Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D53806191
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Feb 15, 2024
…k#43043) Summary: Restores behaviour of `yarn test-e2e-local` when we are not using `--circleciToken`. The `npm pack` logic (necessary for the subsequent `updateTemplatePackage` call before initing `RNTestProject`) was deleted in facebook#41172 / D50651448. facebook@4eed12b#diff-56f57bf0eac99b0fda1b2938aceb8d9b663db82c07cb405bd53a01c8689710ffL224-L240 Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D53806191
|
This pull request has been merged in afc61ab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Restores behaviour of
yarn test-e2e-localwhen we are not using--circleciToken. Thenpm packlogic (necessary for the subsequentupdateTemplatePackagecall before initingRNTestProject) was deleted in #41172 / D50651448.4eed12b#diff-56f57bf0eac99b0fda1b2938aceb8d9b663db82c07cb405bd53a01c8689710ffL224-L240
Changelog: [Internal]
Differential Revision: D53806191