Adjust output package.json formatting in scripts #43133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D54007565 |
huntie
force-pushed
the
export-D54007565
branch
from
7efa0b6 to
daf32b8
Compare
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Feb 22, 2024
Summary: I noticed inconsistent handling of terminating newlines in D54006327@V1, and had also been noticing `yarn build` reformatting unrelated sections of `package.json` files. For now, this logic isn't moved to a shared util, since there will likely be a higher level abstraction for the release scripts in the next batch of improvements. Changelog: [Internal] Reviewed By: lunaleaps, cipolleschi Differential Revision: D54007565
|
This pull request was exported from Phabricator. Differential Revision: D54007565 |
Summary: I noticed inconsistent handling of terminating newlines in D54006327@V1, and had also been noticing `yarn build` reformatting unrelated sections of `package.json` files. For now, this logic isn't moved to a shared util, since there will likely be a higher level abstraction for the release scripts in the next batch of improvements. Changelog: [Internal] Reviewed By: lunaleaps, cipolleschi Differential Revision: D54007565
huntie
force-pushed
the
export-D54007565
branch
from
daf32b8 to
537ef74
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54007565 |
Base commit: b9f3186 |
|
This pull request has been merged in 30b088d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I noticed inconsistent handling of terminating newlines in D54006327@V1, and had also been noticing
yarn buildreformatting unrelated sections ofpackage.jsonfiles.For now, this logic isn't moved to a shared util, since there will likely be a higher level abstraction for the release scripts in the next batch of improvements.
Changelog: [Internal]
Reviewed By: lunaleaps
Differential Revision: D54007565