Reset the autoresizing mask when the view is recycled #43215
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Autoresizing mask is a native property of iOS views. When a veiw is created anew, the default value is `UIViewAutoresizingNone`. Libraries might create code that update this property and we need to make sure that it is reset when the view is recycled. This should close: facebook#42732 ## Changelog: [iOS][Changed] - Reset the autoresizing mask to `UIViewAutoresizingNone` when the view is recycled. Differential Revision: D54263847
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D54263847 |
|
@j-piasecki This should address one of the issue you opened last month, sorry for the delay. One thing I noticed is that the React state in the app in this specific example goes out of sync with this change.
Are we ok with this? I don't think there is a way to propagate this change up to the JS layer, right? Before the change, not resetting the |
|
closing, not the right fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Autoresizing mask is a native property of iOS views. When a veiw is created anew, the default value is
UIViewAutoresizingNone. Libraries might create code that update this property and we need to make sure that it is reset when the view is recycled.This should close: #42732
Changelog:
[iOS][Changed] - Reset the autoresizing mask to
UIViewAutoresizingNonewhen the view is recycled.Differential Revision: D54263847