Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint: Update @typescript-eslint monorepo to v7 & eslint-plugin-jest to v27 #43406

Closed
wants to merge 1 commit into from

Conversation

lluiscab
Copy link
Contributor

@lluiscab lluiscab commented Mar 11, 2024

Summary:

This PR updates @typescript-eslint/eslint-plugin and @typescript-eslint/parser to v7 and eslint-plugin-jest to v27, removing any dependencies on @typescript-eslint v6, allowing projects using @react-native/eslint-config to safely update to @typescript-eslint v7 without having to worry about duplicate major versions installed

Changelog:

  • [General] [Changed]: Updated eslint-plugin-jest to v27
  • [General] [Changed]: Updated @typescript-eslint monorepo to v7

Test Plan:

yarn run lint executed locally successfully

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 11, 2024
Copy link

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 5d4f33b

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Mar 11, 2024
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 18,053,480 -5
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,407,929 +0
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: e2157f0
Branch: main

@facebook-github-bot
Copy link
Contributor

@tdn120 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@lluiscab
Copy link
Contributor Author

Is there any information available on why Facebook Internal - Builds & Tests & Facebook Internal - Linter both failed?

facebook-github-bot pushed a commit to facebook/metro that referenced this pull request Mar 18, 2024
… to v27

Summary:
This PR updates `typescript-eslint/eslint-plugin` and `typescript-eslint/parser` to `v7` and `eslint-plugin-jest` to `v27`, removing any dependencies on `typescript-eslint` `v6`, allowing projects using `react-native/eslint-config` to safely update to  `typescript-eslint` `v7` without having to worry about duplicate major versions installed

## Changelog:

- [General] [Changed]: Updated `eslint-plugin-jest` to `v27`
- [General] [Changed]: Updated `typescript-eslint` monorepo to `v7`

X-link: facebook/react-native#43406

Reviewed By: robhogan

Differential Revision: D54749676

Pulled By: tdn120

fbshipit-source-id: f6fae92fc95333e28b36a3d2bd8470c8869d38bc
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Mar 18, 2024
@facebook-github-bot
Copy link
Contributor

@tdn120 merged this pull request in 91d7251.

@lluiscab lluiscab deleted the eslint-update-deps branch March 18, 2024 18:37
@lluiscab
Copy link
Contributor Author

Since this PR was merged, both 0.74.75 and 0.74.76 versions of @react-native/eslint-plugin have been released but neither seem to include the changes made in this MR, but they are present in 0.75.0-nightly builds (as one would expect).

When can I expect these changes to appear on a 0.74.X version?

@tdn120
Copy link

tdn120 commented Apr 2, 2024

Hey sorry about that, there used to be automated instructions for releases. You'll need to open a pick request here:
https://github.com/reactwg/react-native-releases/issues/new/choose

As for the internal failures, there were other dependencies that needed a similar update, which took a bit of time to sort out.

huntie pushed a commit to huntie/react-native that referenced this pull request Jun 3, 2024
… to v27 (facebook#43406)

Summary:
This PR updates `typescript-eslint/eslint-plugin` and `typescript-eslint/parser` to `v7` and `eslint-plugin-jest` to `v27`, removing any dependencies on `typescript-eslint` `v6`, allowing projects using `react-native/eslint-config` to safely update to  `typescript-eslint` `v7` without having to worry about duplicate major versions installed

## Changelog:

- [General] [Changed]: Updated `eslint-plugin-jest` to `v27`
- [General] [Changed]: Updated `typescript-eslint` monorepo to `v7`

Pull Request resolved: facebook#43406

Test Plan: `yarn run lint` executed locally successfully

Reviewed By: robhogan

Differential Revision: D54749676

Pulled By: tdn120

fbshipit-source-id: f6fae92fc95333e28b36a3d2bd8470c8869d38bc

# Conflicts:
#	package.json
#	packages/eslint-config-react-native/package.json
#	yarn.lock
huntie added a commit that referenced this pull request Jun 4, 2024
… to 7.x (#44764)

Summary:
This PR updates `typescript-eslint/eslint-plugin` and `typescript-eslint/parser` to `v7` and `eslint-plugin-jest` to `v27`, removing any dependencies on `typescript-eslint` `v6`, allowing projects using `react-native/eslint-config` to safely update to  `typescript-eslint` `v7` without having to worry about duplicate major versions installed

## Changelog:

- [General] [Changed]: Updated `eslint-plugin-jest` to `v27`
- [General] [Changed]: Updated `typescript-eslint` monorepo to `v7`

Pull Request resolved: #43406

Test Plan: `yarn run lint` executed locally successfully

Reviewed By: robhogan

Differential Revision: D54749676

Pulled By: tdn120

fbshipit-source-id: f6fae92fc95333e28b36a3d2bd8470c8869d38bc

# Conflicts:
#	package.json
#	packages/eslint-config-react-native/package.json
#	yarn.lock

Co-authored-by: Lluís <lluis@skrit.es>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants