Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small refactor in RuntimeScheduler_Modern to favor references over shared_ptr for non-owning function args #43852

Closed
wants to merge 6 commits into from
Closed

Small refactor in RuntimeScheduler_Modern to favor references over shared_ptr for non-owning function args #43852

wants to merge 6 commits into from

Commits on Apr 9, 2024

  1. Fix problems in PerformanceObserver notifications 

    Differential Revision: D55646390
    @rubennorte @facebook-github-bot
    rubennorte authored and facebook-github-bot committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    09d9a18 View commit details
    Browse the repository at this point in the history

  2. Add example of Event Timing API in RNTester examples 

    Differential Revision: D55646393
    @rubennorte @facebook-github-bot
    rubennorte authored and facebook-github-bot committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    2522fa7 View commit details
    Browse the repository at this point in the history

  3. Decouple PerformanceEntryReporter from NativePerformanceObserver 

    Differential Revision: D55646394
    @rubennorte @facebook-github-bot
    rubennorte authored and facebook-github-bot committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    70cf71b View commit details
    Browse the repository at this point in the history

  4. Move PerformanceEntryReporter to its own target 

    Differential Revision: D55646391
    @rubennorte @facebook-github-bot
    rubennorte authored and facebook-github-bot committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    332ef55 View commit details
    Browse the repository at this point in the history

  5. Decouple event logger from PerformanceEntryReporter and remove singleton 

    Differential Revision: D55646392
    @rubennorte @facebook-github-bot
    rubennorte authored and facebook-github-bot committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    5f163fa View commit details
    Browse the repository at this point in the history

  6. Small refactor in RuntimeScheduler_Modern to favor references over sh… 

    …ared_ptr for non-owning function args (facebook#43852)

Summary:
Pull Request resolved: facebook#43852

Changelog: [internal]

Just a small refactor so we rely less on shared pointers within `RuntimeSCheduler_Modern`.

Reviewed By: javache

Differential Revision: D55646389
    @rubennorte @facebook-github-bot
    rubennorte authored and facebook-github-bot committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    458e874 View commit details
    Browse the repository at this point in the history