Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert interfaces inside devsupport/interfaces to Kotlin #44055

Closed
wants to merge 1 commit into from

Conversation

rshest
Copy link
Contributor

@rshest rshest commented Apr 12, 2024

Summary:

Changelog:

[Internal] -

Was looking into how devsupport is exactly implemented on different platforms (in the context of doing it for a new platform) and figured I may just well convert this to Koltin in the process (helped to understand inner working details as well).

Differential Revision: D56052137

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Apr 12, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56052137

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56052137

rshest added a commit to rshest/react-native that referenced this pull request Apr 12, 2024
…4055)

Summary:
Pull Request resolved: facebook#44055

## Changelog:
[Internal] -

Was looking into how devsupport is exactly implemented on different platforms (in the context of doing it for a new platform) and figured I may just well convert this to Koltin in the process (helped to understand inner working details as well).

Differential Revision: D56052137
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56052137

rshest added a commit to rshest/react-native that referenced this pull request Apr 12, 2024
…4055)

Summary:
Pull Request resolved: facebook#44055

## Changelog:
[Internal] -

Was looking into how devsupport is exactly implemented on different platforms (in the context of doing it for a new platform) and figured I may just well convert this to Koltin in the process (helped to understand inner working details as well).

Differential Revision: D56052137
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56052137

rshest added a commit to rshest/react-native that referenced this pull request Apr 12, 2024
…4055)

Summary:
Pull Request resolved: facebook#44055

## Changelog:
[Internal] -

Was looking into how devsupport is exactly implemented on different platforms (in the context of doing it for a new platform) and figured I may just well convert this to Koltin in the process (helped to understand inner working details as well).

Differential Revision: D56052137
@analysis-bot
Copy link

analysis-bot commented Apr 12, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,385,250 -3
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,760,263 -4
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: b7812a8
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56052137

rshest added a commit to rshest/react-native that referenced this pull request Apr 12, 2024
…4055)

Summary:
Pull Request resolved: facebook#44055

## Changelog:
[Internal] -

Was looking into how devsupport is exactly implemented on different platforms (in the context of doing it for a new platform) and figured I may just well convert this to Koltin in the process (helped to understand inner working details as well).

Differential Revision: D56052137
rshest added a commit to rshest/react-native that referenced this pull request Apr 12, 2024
…4055)

Summary:
Pull Request resolved: facebook#44055

## Changelog:
[Internal] -

Was looking into how devsupport is exactly implemented on different platforms (in the context of doing it for a new platform) and figured I may just well convert this to Koltin in the process (helped to understand inner working details as well).

Differential Revision: https://internalfb.com/D56052137
…4055)

Summary:
Pull Request resolved: facebook#44055

## Changelog:
[Internal] -

Was looking into how devsupport is exactly implemented on different platforms (in the context of doing it for a new platform) and figured I may just well convert this to Koltin in the process (helped to understand inner working details as well).

Differential Revision: D56052137
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56052137

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in b15d438.

Copy link

This pull request was successfully merged by @rshest in b15d438.

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants