Fix: OSS builds can accidentally using coreutils cp #44097
Conversation
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56143216 |
Summary: There are two places where we use a feature specific to the system version of 'cp', the: -X Do not copy Extended Attributes (EAs) or resource forks. This feature isn't available in GNU's cp, which is commonly installed on macOS using: brew install coreutils && brew link coreutils We can avoid the problem alltogether by being specific about the path of the system cp. Changelog: [General][Fixed] don't break script phase and codegen when coreutils installed on macOS Differential Revision: D56143216
blakef
force-pushed
the
export-D56143216
branch
from
e059123
to
f49960c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56143216 |
Base commit: 7047563 |
Summary: There are two places where we use a feature specific to the system version of 'cp', the: -X Do not copy Extended Attributes (EAs) or resource forks. This feature isn't available in GNU's cp, which is commonly installed on macOS using: brew install coreutils && brew link coreutils We can avoid the problem alltogether by being specific about the path of the system cp. Changelog: [General][Fixed] don't break script phase and codegen when coreutils installed on macOS Reviewed By: cipolleschi Differential Revision: D56143216
|
This pull request has been merged in e079953. |
|
This pull request was successfully merged by @blakef in e079953. When will my fix make it into a release? | How to file a pick request? |
Summary: Pull Request resolved: #44097 There are two places where we use a feature specific to the system version of 'cp', the: -X Do not copy Extended Attributes (EAs) or resource forks. This feature isn't available in GNU's cp, which is commonly installed on macOS using: brew install coreutils && brew link coreutils We can avoid the problem alltogether by being specific about the path of the system cp. Changelog: [General][Fixed] don't break script phase and codegen when coreutils installed on macOS Reviewed By: cipolleschi Differential Revision: D56143216 fbshipit-source-id: f1c1ef9ea2f01614d6d89c4e9eedf43113deb80c
|
Although this PR is reasonable, the description of what it fixes is inaccurate. This never affected users who simply ran
In short, this only affects users who have manipulated their PATH variable to put gnu tools higher than the OS X standard tooling. I'm sure there's all sorts of similarly weird and dangerous environment changes I could make which would break XCode or the react-native build... So while this patch is safe, I'm not sure RTN should be accepting patches like this. They adds complexity to the project and every PR has a risk of introducing regressions or derailing a release. All for the meager gain of building better on an incorrectly configured computer. |
Summary:
There are two places where we use a feature specific to the system version of 'cp', the:
-X Do not copy Extended Attributes (EAs) or resource forks.
This feature isn't available in GNU's cp, which is commonly installed on macOS using:
brew install coreutils && brew link coreutils
We can avoid the problem alltogether by being specific about the path of the system cp.
Changelog: [General][Fixed] don't break script phase and codegen when coreutils installed on macOS
Differential Revision: D56143216