Disable view preallocation when batchRenderingUpdatesInEventLoop is enabled #44144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56301318 |
…nabled (facebook#44144) Summary: When using `batchRenderingUpdatesInEventLoop` the Fabric Differentiator may more a newly created ShadowNode and subsequent update (eg coming from a layout effect) into a single MountingTransaction. This enables us to correctly implement layoutEffect in the new architecture and prevent flickering of intermediate states. On Android, we also have a view preallocation mechanism, which will create native views for ShadowNodes as they're created by React. This mechanism is incompatible with `batchRenderingUpdatesInEventLoop` as we will ignore the `create` instruction in the MountingTransaction since we already have a preallocated view. However the props we used for preallocation will be outdated/different compared with the ones in the `MountingTransaction`, which represents a severe regression to the issue described in facebook#44111. Changelog: [Android][Fixed] Mutations to newly created views from useLayoutEffect were not always applied. Differential Revision: D56301318
javache
force-pushed
the
export-D56301318
branch
from
84d3707
to
98b901a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56301318 |
Base commit: f21d9af |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When using
batchRenderingUpdatesInEventLoopthe Fabric Differentiator may more a newly created ShadowNode and subsequent update (eg coming from a layout effect) into a single MountingTransaction. This enables us to correctly implement layoutEffect in the new architecture and prevent flickering of intermediate states.On Android, we also have a view preallocation mechanism, which will create native views for ShadowNodes as they're created by React. This mechanism is incompatible with
batchRenderingUpdatesInEventLoopas we will ignore thecreateinstruction in the MountingTransaction since we already have a preallocated view. However the props we used for preallocation will be outdated/different compared with the ones in theMountingTransaction, which represents a severe regression to the issue described in #44111.Changelog: [Android][Fixed] Mutations to newly created views from useLayoutEffect were not always applied.
Differential Revision: D56301318