Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RNGP - Setup the RunAutolinkingConfigTask to run the config command #44286

Closed
wants to merge 2 commits into from

Conversation

cortinico
Copy link
Contributor

Summary:
This diff is part of RFC0759
react-native-community/discussions-and-proposals#759

Here I'm creating the runAutolinkingConfig task.

This task is responsible of either:

  • Invoking the npx react-native-community/cli config command (or the one specified by the user)
  • Copying the config output file specified by the user (if any).

The task re-executes only if any of the lockfile are actually changed otherwise it just returns as "UP-TO-DATE"

This allows us to

Changelog:
[Internal] [Changed] - RNGP - Setup the RunAutolinkingConfigTask to run the config command

Differential Revision: D55475596

Summary:
This adds 2 fields to RNGP extension to support autolinking inside core.

Changelog:
[Internal] [Changed] - RNGP - Add autolinking fields to ReactExtensions

Differential Revision: D55475597
Summary:
This diff is part of RFC0759
react-native-community/discussions-and-proposals#759

Here I'm creating the `runAutolinkingConfig` task.

This task is responsible of either:
- Invoking the `npx react-native-community/cli config` command (or the one specified by the user)
- Copying the config output file specified by the user (if any).

The task re-executes only if any of the lockfile are actually changed otherwise it just returns as "UP-TO-DATE"

This allows us to

Changelog:
[Internal] [Changed] - RNGP - Setup the RunAutolinkingConfigTask to run the config command

Differential Revision: D55475596
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Apr 26, 2024
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,461,305 +6
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,834,090 +2
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 1f08799
Branch: main

@cortinico
Copy link
Contributor Author

1df1570

@cortinico cortinico closed this Jul 16, 2024
@cortinico cortinico added the Merged This PR has been merged. label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants