introduce CallInvoker API for bridgeless modules #44378
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56807994 |
Base commit: eb1b42f |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
May 3, 2024
…44378) Summary: Changelog: [iOS][Added] introduce CallInvoker support in bridgeless native modules I am adding this API in favor of RCTRuntimeExecutor. CallInvoker is now preferred because after facebook#43375, the CallInvoker has access to the jsi::Runtime. Since the community is using CallInvoker already for their async access use cases, CallInvoker is the preferred choice of RuntimeExecutor / RuntimeScheduler because of easier migration. Also, having a wrapper like CallInvoker will give us more flexibility in the future if we want to expand this API. Reviewed By: RSNara Differential Revision: D56807994
philIip
added a commit
to philIip/react-native
that referenced
this pull request
May 3, 2024
…44378) Summary: Changelog: [iOS][Added] introduce CallInvoker support in bridgeless native modules I am adding this API in favor of RCTRuntimeExecutor. CallInvoker is now preferred because after facebook#43375, the CallInvoker has access to the jsi::Runtime. Since the community is using CallInvoker already for their async access use cases, CallInvoker is the preferred choice of RuntimeExecutor / RuntimeScheduler because of easier migration. Also, having a wrapper like CallInvoker will give us more flexibility in the future if we want to expand this API. Reviewed By: RSNara Differential Revision: D56807994
philIip
added a commit
to philIip/react-native
that referenced
this pull request
May 3, 2024
Summary: Changelog: [iOS][Added] introduce CallInvoker support in bridgeless native modules I am adding this API in favor of RCTRuntimeExecutor. CallInvoker is now preferred because after facebook#43375, the CallInvoker has access to the jsi::Runtime. Since the community is using CallInvoker already for their async access use cases, CallInvoker is the preferred choice of RuntimeExecutor / RuntimeScheduler because of easier migration. Also, having a wrapper like CallInvoker will give us more flexibility in the future if we want to expand this API. Reviewed By: RSNara Differential Revision: D56807994
philIip
added a commit
to philIip/react-native
that referenced
this pull request
May 3, 2024
…44378) Summary: Changelog: [iOS][Added] introduce CallInvoker support in bridgeless native modules I am adding this API in favor of RCTRuntimeExecutor. CallInvoker is now preferred because after facebook#43375, the CallInvoker has access to the jsi::Runtime. Since the community is using CallInvoker already for their async access use cases, CallInvoker is the preferred choice of RuntimeExecutor / RuntimeScheduler because of easier migration. Also, having a wrapper like CallInvoker will give us more flexibility in the future if we want to expand this API. Reviewed By: RSNara Differential Revision: D56807994
|
This pull request was exported from Phabricator. Differential Revision: D56807994 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
May 3, 2024
…44378) Summary: Changelog: [iOS][Added] introduce CallInvoker support in bridgeless native modules I am adding this API in favor of RCTRuntimeExecutor. CallInvoker is now preferred because after facebook#43375, the CallInvoker has access to the jsi::Runtime. Since the community is using CallInvoker already for their async access use cases, CallInvoker is the preferred choice of RuntimeExecutor / RuntimeScheduler because of easier migration. Also, having a wrapper like CallInvoker will give us more flexibility in the future if we want to expand this API. Reviewed By: RSNara Differential Revision: D56807994
Summary: Changelog: [iOS][Added] introduce CallInvoker support in bridgeless native modules I am adding this API in favor of RCTRuntimeExecutor. CallInvoker is now preferred because after facebook#43375, the CallInvoker has access to the jsi::Runtime. Since the community is using CallInvoker already for their async access use cases, CallInvoker is the preferred choice of RuntimeExecutor / RuntimeScheduler because of easier migration. Also, having a wrapper like CallInvoker will give us more flexibility in the future if we want to expand this API. Reviewed By: RSNara Differential Revision: D56807994
philIip
added a commit
to philIip/react-native
that referenced
this pull request
May 3, 2024
…44378) Summary: Changelog: [iOS][Added] introduce CallInvoker support in bridgeless native modules I am adding this API in favor of RCTRuntimeExecutor. CallInvoker is now preferred because after facebook#43375, the CallInvoker has access to the jsi::Runtime. Since the community is using CallInvoker already for their async access use cases, CallInvoker is the preferred choice of RuntimeExecutor / RuntimeScheduler because of easier migration. Also, having a wrapper like CallInvoker will give us more flexibility in the future if we want to expand this API. Reviewed By: RSNara Differential Revision: D56807994
philIip
added a commit
to philIip/react-native
that referenced
this pull request
May 3, 2024
…44378) Summary: Changelog: [iOS][Added] introduce CallInvoker support in bridgeless native modules I am adding this API in favor of RCTRuntimeExecutor. CallInvoker is now preferred because after facebook#43375, the CallInvoker has access to the jsi::Runtime. Since the community is using CallInvoker already for their async access use cases, CallInvoker is the preferred choice of RuntimeExecutor / RuntimeScheduler because of easier migration. Also, having a wrapper like CallInvoker will give us more flexibility in the future if we want to expand this API. Reviewed By: RSNara Differential Revision: D56807994
philIip
added a commit
to philIip/react-native
that referenced
this pull request
May 3, 2024
…44378) Summary: Changelog: [iOS][Added] introduce CallInvoker support in bridgeless native modules I am adding this API in favor of RCTRuntimeExecutor. CallInvoker is now preferred because after facebook#43375, the CallInvoker has access to the jsi::Runtime. Since the community is using CallInvoker already for their async access use cases, CallInvoker is the preferred choice of RuntimeExecutor / RuntimeScheduler because of easier migration. Also, having a wrapper like CallInvoker will give us more flexibility in the future if we want to expand this API. Reviewed By: RSNara Differential Revision: D56807994
|
This pull request was exported from Phabricator. Differential Revision: D56807994 |
|
This pull request has been merged in 8f9ff89. |
|
This pull request was successfully merged by @philIip in 8f9ff89. When will my fix make it into a release? | How to file a pick request? |
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
May 6, 2024
Summary: Pull Request resolved: facebook#44378 Changelog: [iOS][Added] introduce CallInvoker support in bridgeless native modules I am adding this API in favor of RCTRuntimeExecutor. CallInvoker is now preferred because after facebook#43375, the CallInvoker has access to the jsi::Runtime. Since the community is using CallInvoker already for their async access use cases, CallInvoker is the preferred choice of RuntimeExecutor / RuntimeScheduler because of easier migration. Also, having a wrapper like CallInvoker will give us more flexibility in the future if we want to expand this API. Reviewed By: RSNara Differential Revision: D56807994 fbshipit-source-id: 5c3585356d016a50645eda3af2d3bbe00298b4e4
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
Summary: Pull Request resolved: facebook#44378 Changelog: [iOS][Added] introduce CallInvoker support in bridgeless native modules I am adding this API in favor of RCTRuntimeExecutor. CallInvoker is now preferred because after facebook#43375, the CallInvoker has access to the jsi::Runtime. Since the community is using CallInvoker already for their async access use cases, CallInvoker is the preferred choice of RuntimeExecutor / RuntimeScheduler because of easier migration. Also, having a wrapper like CallInvoker will give us more flexibility in the future if we want to expand this API. Reviewed By: RSNara Differential Revision: D56807994 fbshipit-source-id: 5c3585356d016a50645eda3af2d3bbe00298b4e4
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Sep 12, 2024
Summary: We should use [BindingsInstaller](facebook#44486) and [RCTCallInvoker](facebook#44378) instead. ## Changelog: [iOS][Breaking] - We deprecated RCTRuntimeExecutor in 0.76, so let's get rid of the code now. Reviewed By: cipolleschi Differential Revision: D62469005
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 12, 2024
Summary: Pull Request resolved: #46466 We should use [BindingsInstaller](#44486) and [RCTCallInvoker](#44378) instead. ## Changelog: [iOS][Breaking] - We deprecated RCTRuntimeExecutor in 0.76, so let's get rid of the code now. Reviewed By: cipolleschi Differential Revision: D62469005 fbshipit-source-id: 3ed033b08f52823bd42f8a57d5d6ab40e35d30f1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [iOS][Added] introduce CallInvoker support in bridgeless native modules
I am adding this API in favor of RCTRuntimeExecutor. CallInvoker is now preferred because after #43375, the CallInvoker has access to the jsi::Runtime. Since the community is using CallInvoker already for their async access use cases, CallInvoker is the preferred choice of RuntimeExecutor / RuntimeScheduler because of easier migration. Also, having a wrapper like CallInvoker will give us more flexibility in the future if we want to expand this API.
Differential Revision: D56807994