Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate ImageLoaderModule to Kotlin #44413

Closed
wants to merge 1 commit into from

Conversation

rshest
Copy link
Contributor

@rshest rshest commented May 5, 2024

Summary:

Changelog:

[Internal] -

As in the title, the corresponding module is migrated from Java to Kotlin.

Differential Revision: D56978931

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels May 5, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56978931

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56978931

rshest added a commit to rshest/react-native that referenced this pull request May 5, 2024
Summary:
Pull Request resolved: facebook#44413

## Changelog:
[Internal] -

As in the title, the corresponding module is migrated from Java to Kotlin.

Differential Revision: D56978931
@rshest rshest force-pushed the export-D56978931 branch from 24f789b to f527cb2 Compare May 5, 2024 10:06
@analysis-bot
Copy link

analysis-bot commented May 5, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,495,012 -2
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,867,568 -3
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: a881b51
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56978931

rshest added a commit to rshest/react-native that referenced this pull request May 5, 2024
Summary:
Pull Request resolved: facebook#44413

## Changelog:
[Internal] -

As in the title, the corresponding module is migrated from Java to Kotlin.

Differential Revision: D56978931
@rshest rshest force-pushed the export-D56978931 branch from f527cb2 to a5bce07 Compare May 5, 2024 10:39
Summary:
Pull Request resolved: facebook#44413

## Changelog:
[Internal] -

As in the title, the corresponding module is migrated from Java to Kotlin.

Differential Revision: D56978931
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56978931

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 7558d5f.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 5, 2024
Copy link

github-actions bot commented May 5, 2024

This pull request was successfully merged by @rshest in 7558d5f.

When will my fix make it into a release? | How to file a pick request?

kosmydel pushed a commit to kosmydel/react-native that referenced this pull request May 6, 2024
Summary:
Pull Request resolved: facebook#44413

## Changelog:
[Internal] -

As in the title, the corresponding module is migrated from Java to Kotlin.

Reviewed By: christophpurrer

Differential Revision: D56978931

fbshipit-source-id: e1e8f22ad9bd2f594bc7cf77c6344f8f23996bcc
kosmydel pushed a commit to kosmydel/react-native that referenced this pull request Jun 11, 2024
Summary:
Pull Request resolved: facebook#44413

## Changelog:
[Internal] -

As in the title, the corresponding module is migrated from Java to Kotlin.

Reviewed By: christophpurrer

Differential Revision: D56978931

fbshipit-source-id: e1e8f22ad9bd2f594bc7cf77c6344f8f23996bcc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants