Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate fabric.mounting.mountitems subset to Kotlin #44440

Closed
wants to merge 1 commit into from

Conversation

rshest
Copy link
Contributor

@rshest rshest commented May 7, 2024

Summary:

Changelog:

[Internal] -

As in the title, note that there are more files there to migrate, will come separately, to make reviewing easier.

Differential Revision: D57046953

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels May 7, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57046953

@analysis-bot
Copy link

analysis-bot commented May 7, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,495,262 -25
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,867,590 -32
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 06eea61
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57046953

rshest added a commit to rshest/react-native that referenced this pull request May 7, 2024
Summary:
Pull Request resolved: facebook#44440

# Changelog:
[Internal] -

As in the title, note that there are more files there to migrate, will come separately, to make reviewing easier.

Reviewed By: javache

Differential Revision: D57046953
@rshest rshest force-pushed the export-D57046953 branch from 62260bb to 6f8b60c Compare May 7, 2024 14:05
Summary:
Pull Request resolved: facebook#44440

# Changelog:
[Internal] -

As in the title, note that there are more files there to migrate, will come separately, to make reviewing easier.

Reviewed By: javache

Differential Revision: D57046953
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57046953

@rshest rshest force-pushed the export-D57046953 branch from 6f8b60c to cbb4e1d Compare May 7, 2024 14:13
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 7, 2024
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 12110a4.

Copy link

github-actions bot commented May 7, 2024

This pull request was successfully merged by @rshest in 12110a4.

When will my fix make it into a release? | How to file a pick request?

kosmydel pushed a commit to kosmydel/react-native that referenced this pull request Jun 11, 2024
Summary:
Pull Request resolved: facebook#44440

# Changelog:
[Internal] -

As in the title, note that there are more files there to migrate, will come separately, to make reviewing easier.

Reviewed By: javache

Differential Revision: D57046953

fbshipit-source-id: e45316da1ed9caaa4daafa96dfabfd374926bd73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants