docs(react-native): fix app build.gradle react config default paths #44472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current paths points to the android folder, but should point to the project root. Currently the android build fails if one uncomments the folder paths, using the default value.
facebook-github-bot
added
CLA Signed
Base commit: deee037 |
cipolleschi
approved these changes
May 8, 2024
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @monholm in 2d8c6f5. When will my fix make it into a release? | How to file a pick request? |
blakef
pushed a commit
to react-native-community/template
that referenced
this pull request
Jun 4, 2024
…#44472) Summary: Minor inconvenience I noticed while doing some testing in a mono-repo. The current paths points to the android folder, but should point to the project root. Currently the android build fails if one uncomments the folder paths as they are. ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID] [FIXED] - Fix incorrect paths in app build.gradle react config block For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [ANDROID] [FIXED] - Fix incorrect paths in app build.gradle react config block Pull Request resolved: facebook/react-native#44472 Test Plan: Uncomment the paths are they are and notice the android build error: ``` FAILURE: Build failed with an exception. * What went wrong: A problem occurred configuring project ':app'. > Failed to notify project evaluation listener. > /xyz/xyz/xyz/xyz/RNPathTester/android/node_modules/react-native/ReactAndroid/gradle.properties (No such file or directory) ``` Use the updated paths and notice the build succeeds 🥳 Reviewed By: GijsWeterings Differential Revision: D57093768 Pulled By: cipolleschi fbshipit-source-id: 8472151c74c7aa5c51dc75f9adda6116387bdf99 Original: facebook/react-native@2d8c6f5
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
…acebook#44472) Summary: Minor inconvenience I noticed while doing some testing in a mono-repo. The current paths points to the android folder, but should point to the project root. Currently the android build fails if one uncomments the folder paths as they are. ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID] [FIXED] - Fix incorrect paths in app build.gradle react config block For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [ANDROID] [FIXED] - Fix incorrect paths in app build.gradle react config block Pull Request resolved: facebook#44472 Test Plan: Uncomment the paths are they are and notice the android build error: ``` FAILURE: Build failed with an exception. * What went wrong: A problem occurred configuring project ':app'. > Failed to notify project evaluation listener. > /xyz/xyz/xyz/xyz/RNPathTester/android/node_modules/react-native/ReactAndroid/gradle.properties (No such file or directory) ``` Use the updated paths and notice the build succeeds 🥳 Reviewed By: GijsWeterings Differential Revision: D57093768 Pulled By: cipolleschi fbshipit-source-id: 8472151c74c7aa5c51dc75f9adda6116387bdf99
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Minor inconvenience I noticed while doing some testing in a mono-repo.
The current paths points to the android folder, but should point to the project root. Currently the android build fails if one uncomments the folder paths as they are.
Changelog:
[ANDROID] [FIXED] - Fix incorrect paths in app build.gradle react config block
Test Plan:
Uncomment the paths are they are and notice the android build error:
Use the updated paths and notice the build succeeds 🥳