Convert FpsDebugFrameCallback/AnimationsDebugModule to Kotlin #44475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57095896 |
Summary: I was tried to fix breaking changes for Expo's React Native nightlies CI testing. Recently React Native core has some effort to migrate Java code to Kotlin. Since facebook@a977b2e69, we cannot reuse the `DevSupportManagerBase` and replace `DevInternalSettings` inside [expo-dev-client](https://github.com/expo/expo/blob/26c9f49042f53db7d37f832c133d4da0f6d64f02/packages/expo-dev-launcher/android/src/debug/java/expo/modules/devlauncher/helpers/DevLauncherReactUtils.kt#L117-L126) because we cannot access to the `DevInternalSettings` anymore because Kotlin "internal" visibility. This PR tries to decouple `DevInternalSettings` from `DevSupportManagerBase` then we could still use reflection to change the mDevSettings. ## Changelog: [ANDROID] [CHANGED] - Decouple `DevInternalSettings` from `DevSupportManagerBase` Pull Request resolved: facebook#44441 Test Plan: CI passed Differential Revision: https://internalfb.com/D57054234
…ok#44475) Summary: Pull Request resolved: facebook#44475 # Changelog: [Internal] - As the title says, this is preparing to complete the conversion of the whole corresponding module to Kotlin. Differential Revision: D57095896
|
This pull request was exported from Phabricator. Differential Revision: D57095896 |
Base commit: deee037 |
|
This pull request has been merged in 7ec70a9. |
|
This pull request was successfully merged by @rshest in 7ec70a9. When will my fix make it into a release? | How to file a pick request? |
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
…ok#44475) Summary: Pull Request resolved: facebook#44475 # Changelog: [Internal] - As the title says, this is preparing to complete the conversion of the whole corresponding module to Kotlin. Reviewed By: christophpurrer Differential Revision: D57095896 fbshipit-source-id: 87fe08aec974f5f1327189d0e74c3782c4391e85
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Internal] -
As the title says, this is preparing to complete the conversion of the whole corresponding module to Kotlin.
Differential Revision: D57095896