Flatten Text examples in RNTester to make them searchable #44518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57197676 |
|
This pull request was exported from Phabricator. Differential Revision: D57197676 |
…4518) Summary: # Changelog: [Internal] - For some inexplicable reason, we had majority of `Text` test examples (42 out of 46) in RNTester stuffed into `<RNTesterBlock/>` components inside one huge "Basic" test case. This was highly imbalanced, introduced extra nesting, cluttering the UI, but most importantly, none of those 42 out 46 test cases were searchable for. This change flattens all of the corresponding nested test cases to the top level, making them into valid separate test cases, which are also searchable. It also corresponds to the general structure we have in other test examples, such as `TextInput`. Differential Revision: D57197676
|
This pull request was exported from Phabricator. Differential Revision: D57197676 |
|
This pull request has been merged in f8c1ad6. |
|
This pull request was successfully merged by @rshest in f8c1ad6. When will my fix make it into a release? | How to file a pick request? |
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
…4518) Summary: Pull Request resolved: facebook#44518 # Changelog: [Internal] - For some inexplicable reason, we had majority of `Text` test examples (42 out of 46) in RNTester stuffed into `<RNTesterBlock/>` components inside one huge "Basic" test case. This was highly imbalanced, introduced extra nesting, cluttering the UI, but most importantly, none of those 42 out 46 test cases were searchable for. This change flattens all of the corresponding nested test cases to the top level, making them into valid separate test cases, which are also searchable. It also corresponds to the general structure we have in other test examples, such as `TextInput`. Reviewed By: cipolleschi Differential Revision: D57197676 fbshipit-source-id: 777eb2aa238a91bb3f52d2f0ab10edc6bfad5c85
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Internal] -
Differential Revision: D57197676