-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix startTransition inside renderers when _callbacks is undefined #44586
Conversation
e699598
to
3280e04
Compare
packages/react-native/Libraries/Renderer/implementations/ReactFabric-prod.js
Outdated
Show resolved
Hide resolved
3280e04
to
6f09893
Compare
these files are synced from react and shouldn't be modified directly here. ideally, we'd create a minimal repro with react-native (without any third-party dependencies) and post it on an issue here. or, if you believe you know what is causing this in react, you could create an issue on react with a repro or a pr with a failing test that demonstrates it |
Thanks for having a look @brentvatne, have a minimal repo here: https://github.com/sync/Shift |
I’ll have a look at the original files and see if anything changed in between versions |
so yes the code is brand new (from 2 months ago) and was added in this commit: 3272b05 |
Code on the react repo that introduced this is very recent: acdlite/react@85b296e and master no longer have this code (it was removed here: acdlite/react@12a387d) |
Happy to close this, readers got updated |
this still hapenning in react native 0.75.3 bridgeless mode |
Summary:
When using
startTransition
using latest react-native (0.74.1, new arch enabled) we get this error:You can easily reproduce this issue creating a new react-native app (latest) and add a transition and execute it.
Sample app here: https://github.com/sync/Shift
Changelog:
[GENERAL] [FIXED] - fixed startTransition inside renderers when _callbacks is undefined
Test Plan:
Before
After
all good with the patch: sync/Shift#1