Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DevSupport classes included in release build with proguard enabled. Resolves unnecessary usage of BridgeDevSupportManager in DevLoadingModule. #44698

Closed
wants to merge 2 commits into from
Closed

DevSupport classes included in release build with proguard enabled. Resolves unnecessary usage of BridgeDevSupportManager in DevLoadingModule. #44698

wants to merge 2 commits into from

Commits on May 28, 2024

  1. Remove dependency on BridgeDevSupportManager 

    DevLoadingModule was using BridgeDevSupportManager to initialize DevLoadingViewManager. This meant a lot of devsupport classes were included in the relase APK.
This commit refactors DevLoadingModule to use only the DevSupportManager interface to mitigate the above problem.
DevSupportManagerBase always creates an instance of DevLoadingViewManager, which is why it need not be initialized again in DevLoadingModule.
Removing old related unused methods from BridgeDevSupportManager
    @garvsgit
    garvsgit committed May 28, 2024
    Configuration menu
    Copy the full SHA
    68d4abf View commit details
    Browse the repository at this point in the history

  2. Add null check on show() 

    Adding a null check on show() in DevLoadingModule which seems to have been missed.
    @garvsgit
    garvsgit committed May 28, 2024
    Configuration menu
    Copy the full SHA
    c370ea9 View commit details
    Browse the repository at this point in the history